From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 14 Sep 2011 09:17:37 +0200 Subject: [U-Boot] [PATCH 03/15] FEC: Add support for iMX28 quirks In-Reply-To: <1315800409-19876-4-git-send-email-marek.vasut@gmail.com> References: <1315800409-19876-1-git-send-email-marek.vasut@gmail.com> <1315800409-19876-4-git-send-email-marek.vasut@gmail.com> Message-ID: <4E705511.6080409@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/12/2011 06:06 AM, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Ben Warren > Cc: Stefano Babic > Cc: Wolfgang Denk > Cc: Detlev Zundel > --- Hi Marek, only a small question: > drivers/net/fec_mxc.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 42 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index cfe2176..f50433dd 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -42,6 +42,14 @@ DECLARE_GLOBAL_DATA_PTR; > #define CONFIG_FEC_XCV_TYPE MII100 > #endif > > +/* > + * The i.MX28 operates with packets in big endian. We need to swap them before > + * sending and after receiving. > + */ > +#ifdef CONFIG_MX28 > +#define CONFIG_FEC_MXC_SWAP_PACKET > +#endif > + Do we really need two defines ? If the MX28 has the oddity to swap packets and this must be always done for this SOC, we could protect the code only with CONFIG_MX28. I think in the code it is already clear that in case of MX28 the packets are swapped. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================