* [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option
@ 2011-09-13 22:26 Fabio Estevam
2011-09-14 7:42 ` Stefano Babic
2011-09-14 7:45 ` Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2011-09-13 22:26 UTC (permalink / raw)
To: u-boot
commit e5226e63 (Makefile: remove tx25 exception) missed to pass NAND_U_BOOT
option when moving tx25 target to boards.cfg.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
boards.cfg | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/boards.cfg b/boards.cfg
index 1e2ff43..58f677f 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -148,7 +148,7 @@ sheevaplug arm arm926ejs - Marvell
dockstar arm arm926ejs - Seagate kirkwood
jadecpu arm arm926ejs jadecpu syteco mb86r0x
mx25pdk arm arm926ejs mx25pdk freescale mx25 mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
-tx25 arm arm926ejs tx25 karo mx25
+tx25 arm arm926ejs tx25 karo mx25 tx25:NAND_U_BOOT
zmx25 arm arm926ejs zmx25 syteco mx25
imx27lite arm arm926ejs imx27lite logicpd mx27
magnesium arm arm926ejs imx27lite logicpd mx27
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option
2011-09-13 22:26 [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option Fabio Estevam
@ 2011-09-14 7:42 ` Stefano Babic
2011-09-14 7:45 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2011-09-14 7:42 UTC (permalink / raw)
To: u-boot
On 09/14/2011 12:26 AM, Fabio Estevam wrote:
> commit e5226e63 (Makefile: remove tx25 exception) missed to pass NAND_U_BOOT
> option when moving tx25 target to boards.cfg.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Hi Fabio,
> ---
> boards.cfg | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Right, that is true. However, the patch is not yet in mainline, I have
errouneously put it into my next branch (I should not), and we can
modify the original patch before merging.
The patch is already in "Change requested" status, because also Wolfgang
found that I missed NAND_U_BOOT. I have really forgotten to resend a new
version, and thanks for your remind and for checking my next branch ;-).
I will send V2.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option
2011-09-13 22:26 [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option Fabio Estevam
2011-09-14 7:42 ` Stefano Babic
@ 2011-09-14 7:45 ` Stefano Babic
2011-09-14 11:26 ` Fabio Estevam
1 sibling, 1 reply; 4+ messages in thread
From: Stefano Babic @ 2011-09-14 7:45 UTC (permalink / raw)
To: u-boot
On 09/14/2011 12:26 AM, Fabio Estevam wrote:
> commit e5226e63 (Makefile: remove tx25 exception) missed to pass NAND_U_BOOT
> option when moving tx25 target to boards.cfg.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> boards.cfg | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Hi Fabio,
> diff --git a/boards.cfg b/boards.cfg
> index 1e2ff43..58f677f 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -148,7 +148,7 @@ sheevaplug arm arm926ejs - Marvell
> dockstar arm arm926ejs - Seagate kirkwood
> jadecpu arm arm926ejs jadecpu syteco mb86r0x
> mx25pdk arm arm926ejs mx25pdk freescale mx25 mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
> -tx25 arm arm926ejs tx25 karo mx25
> +tx25 arm arm926ejs tx25 karo mx25 tx25:NAND_U_BOOT
> zmx25 arm arm926ejs zmx25 syteco mx25
> imx27lite arm arm926ejs imx27lite logicpd mx27
> magnesium arm arm926ejs imx27lite logicpd mx27
I was too fast...I reread the whole thread
(http://patchwork.ozlabs.org/patch/112080/)
CONFIG_NAND_U_BOOT is defined in tx25.h, and there is no need to define
it again. I think the actual patch is ok. Have you seen any problem ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option
2011-09-14 7:45 ` Stefano Babic
@ 2011-09-14 11:26 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2011-09-14 11:26 UTC (permalink / raw)
To: u-boot
On Wed, Sep 14, 2011 at 4:45 AM, Stefano Babic <sbabic@denx.de> wrote:
...
> I was too fast...I reread the whole thread
> (http://patchwork.ozlabs.org/patch/112080/)
> ?CONFIG_NAND_U_BOOT is defined in tx25.h, and there is no need to define
> it again. I think the actual patch is ok. Have you seen any problem ?
Ok, thanks for the clarification. Your original patch looks good then.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-14 11:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-13 22:26 [U-Boot] [PATCH] MX25: tx25: Pass NAND_U_BOOT option Fabio Estevam
2011-09-14 7:42 ` Stefano Babic
2011-09-14 7:45 ` Stefano Babic
2011-09-14 11:26 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox