From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net, davinci_emac: add KSZ8864 switch
Date: Fri, 16 Sep 2011 07:46:05 +0200 [thread overview]
Message-ID: <4E72E29D.7070206@denx.de> (raw)
In-Reply-To: <201109151132.09319.vapier@gentoo.org>
Hello Mike,
Mike Frysinger wrote:
> On Thursday, September 15, 2011 01:36:09 Heiko Schocher wrote:
>> --- /dev/null
>> +++ b/arch/arm/cpu/arm926ejs/davinci/ksz8873.c
>>
>> +#ifdef CONFIG_DRIVER_TI_EMAC
>
> this file is only built when this is defined, so this is useless
>
>> +#ifdef CONFIG_CMD_NET
>
> building net drivers but not enabling CMD_NET is a config error. dont bother
> checking this yourself.
Post this change in a v2, thanks for the review!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-09-16 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 5:36 [U-Boot] [PATCH] net, davinci_emac: add KSZ8864 switch Heiko Schocher
2011-09-15 15:32 ` Mike Frysinger
2011-09-16 5:46 ` Heiko Schocher [this message]
2011-09-19 5:49 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-09-23 19:35 ` Paulraj, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E72E29D.7070206@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox