From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 16 Sep 2011 07:46:05 +0200 Subject: [U-Boot] [PATCH] net, davinci_emac: add KSZ8864 switch In-Reply-To: <201109151132.09319.vapier@gentoo.org> References: <1316064969-5617-1-git-send-email-hs@denx.de> <201109151132.09319.vapier@gentoo.org> Message-ID: <4E72E29D.7070206@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Mike, Mike Frysinger wrote: > On Thursday, September 15, 2011 01:36:09 Heiko Schocher wrote: >> --- /dev/null >> +++ b/arch/arm/cpu/arm926ejs/davinci/ksz8873.c >> >> +#ifdef CONFIG_DRIVER_TI_EMAC > > this file is only built when this is defined, so this is useless > >> +#ifdef CONFIG_CMD_NET > > building net drivers but not enabling CMD_NET is a config error. dont bother > checking this yourself. Post this change in a v2, thanks for the review! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany