From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 16 Sep 2011 13:56:13 +0200 Subject: [U-Boot] [PATCH 8/8] MX35: add support for flea3 board In-Reply-To: References: <1316166383-11314-1-git-send-email-sbabic@denx.de> <1316166383-11314-8-git-send-email-sbabic@denx.de> Message-ID: <4E73395D.7050105@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/16/2011 01:48 PM, Fabio Estevam wrote: > Hi Stefano, > Hi Fabio, > On Fri, Sep 16, 2011 at 6:46 AM, Stefano Babic wrote: > .. >> +void board_setup_sdram(void) >> +{ >> + u32 val; >> + struct esdc_regs *esdc = (struct esdc_regs *)ESDCTL_BASE_ADDR; >> + >> + /* Initialize with default values both CSD0/1 */ >> + writel(0x2000, &esdc->esdctl0); >> + writel(0x2000, &esdc->esdctl1); > > On other boards we setup the SDRAM in lowlevel_init.S and here you do > it on the board file. > > Shouldn?t this be setup in lowlevel_init.S for consistency? Really the idea is to get rid (as much as possible) of lowlevel_init.S and make the whole setup in C code. This board can be then the first one (MX3) doing that, that makes the code much more readable - and I see in recent patches that this is pushed for other architectures, too (I mean Heiko's patches for davinci AM1808). And this is done since a lot of time for some PowerPC boards. The question arises if the other boards (at least the mx35pdk..) should be updated in the same way... Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================