From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Fri, 16 Sep 2011 21:08:28 +0200
Subject: [U-Boot] [PATCH 1/3] image: add support for Android's boot
 image format
In-Reply-To: <201109161422.39483.vapier@gentoo.org>
References: <1316191879-27214-1-git-send-email-bigeasy@linutronix.de>
	<1316191879-27214-2-git-send-email-bigeasy@linutronix.de>
	<201109161422.39483.vapier@gentoo.org>
Message-ID: <4E739EAC.8020603@linutronix.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/16/2011 08:22 PM, Mike Frysinger wrote:
> On Friday, September 16, 2011 12:51:17 Sebastian Andrzej Siewior wrote:
>> +#ifdef CONFIG_ANDROID_BOOT_IMAGE
>
> we already have a standard here: CONFIG_BOOTM_ANDROID

Ehm. Can't follow. If you want me to s/CONFIG_ANDROID_BOOT_IMAGE
/CONFIG_BOOTM_ANDROID/ I sure can do this. The uImage has no CONFIG
around it and the other format has CONFIG_FIT around it.
A grep for CONFIG_BOOTM_ returns LINUX, NETBSD and others. They differ
in the calling ABI, argument passing etc. I do boot here a Linux image
but not from an uImage.

>> +static u32 andoir_img_get_kload(struct andr_img_hdr *hdr)
>
> looks like you missed a "d" in that "andoir"

yup, fixing, thanks.

> -mike

Sebastian