From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 RESEND] SPL: Allow user to disable CPU support library
Date: Fri, 16 Sep 2011 14:49:28 -0500 [thread overview]
Message-ID: <4E73A848.2050500@freescale.com> (raw)
In-Reply-To: <201109160117.03992.marek.vasut@gmail.com>
On 09/15/2011 06:17 PM, Marek Vasut wrote:
> On Friday, September 16, 2011 12:57:44 AM Scott Wood wrote:
>> On 09/11/2011 11:03 PM, Marek Vasut wrote:
>>> Introduce CONFIG_SPL_NO_CPU_SUPPORT_CODE to avoid compiling the CPU
>>> support library. This can be useful on some setups.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Cc: Wolfgang Denk <wd@denx.de>
>>> Cc: Detlev Zundel <dzu@denx.de>
>>> Cc: Chander Kashyap <chander.kashyap@linaro.org>
>>
>> But you didn't CC these...
>
> git send-email should handle those ?
I'm not too familiar with git send-email, but they're not in the CC list
of the actual e-mail.
>>> +# In case we want to avoid the CPU support code, we need to define this:
>>> +ifndef CONFIG_SPL_NO_CPU_SUPPORT_CODE
>>> +SPL_CPU_SUPPORT_CODE := y
>>> +endif
>>
>> SPL should ideally contain nothing by default. Have options that say
>> what you do want to pull in, not what you don't want.
>
> You usually DO want to pull this in (because it contains vectoring code, really
> basic lowlevel init etc), there are only border cases where you do not want to
> do that and use your own.
Sorry, I was a bit confused by seeing lib$(CPU), thought at first you
were trying to pull in stuff like arch/$(ARCH)/lib.
Still, this seems hackish. Shouldn't the control be on specific files
that you include, not directories?
-Scott
next prev parent reply other threads:[~2011-09-16 19:49 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 4:03 [U-Boot] [PATCH 0/2] SPL improvements Marek Vasut
2011-09-12 4:03 ` [U-Boot] [PATCH 1/2 RESEND] SPL: Make path to start.S configurable Marek Vasut
2011-10-05 19:08 ` Wolfgang Denk
2011-10-05 20:07 ` Wolfgang Denk
2011-10-05 20:15 ` Wolfgang Denk
2011-09-12 4:03 ` [U-Boot] [PATCH 2/2 RESEND] SPL: Allow user to disable CPU support library Marek Vasut
2011-09-15 22:57 ` Scott Wood
2011-09-15 23:17 ` Marek Vasut
2011-09-16 19:49 ` Scott Wood [this message]
2011-09-16 21:38 ` Marek Vasut
2011-09-16 21:42 ` Scott Wood
2011-09-16 21:47 ` Marek Vasut
2011-09-16 22:07 ` Scott Wood
2011-09-16 22:48 ` Marek Vasut
2011-09-19 18:13 ` Scott Wood
2011-09-19 22:31 ` Marek Vasut
2011-09-20 19:12 ` Scott Wood
2011-09-20 21:16 ` Marek Vasut
2011-09-20 21:23 ` Scott Wood
2011-09-20 21:30 ` Marek Vasut
2011-09-20 23:31 ` Scott Wood
2011-09-22 8:52 ` Marek Vasut
2011-10-05 21:44 ` Tom Rini
2011-10-05 22:02 ` Scott Wood
2011-10-05 22:20 ` Marek Vasut
2011-10-06 0:13 ` [U-Boot] [PATCH 1/2] " Marek Vasut
2011-10-06 0:13 ` [U-Boot] [PATCH 2/2] SPL: Allow ARM926EJS to avoid compiling in the CPU support code Marek Vasut
2011-10-18 21:33 ` Albert ARIBAUD
2011-10-18 22:30 ` Marek Vasut
2011-10-21 20:44 ` Marek Vasut
2011-10-21 21:52 ` Albert ARIBAUD
2011-10-21 22:00 ` Marek Vasut
2011-10-21 22:44 ` Albert ARIBAUD
2011-10-21 22:46 ` Marek Vasut
2011-10-21 23:08 ` Albert ARIBAUD
2011-10-21 23:45 ` Marek Vasut
2011-10-22 0:04 ` Tom Rini
2011-10-22 0:19 ` Marek Vasut
2011-10-22 0:41 ` Albert ARIBAUD
2011-10-22 1:20 ` Marek Vasut
2011-10-22 7:05 ` Albert ARIBAUD
2011-10-24 10:14 ` [U-Boot] [PATCH 2/2 V2] " Marek Vasut
2011-11-03 0:05 ` Marek Vasut
2011-11-04 13:59 ` Marek Vasut
2011-11-08 21:15 ` Albert ARIBAUD
2011-10-06 15:54 ` [U-Boot] [PATCH 1/2] SPL: Allow user to disable CPU support library Scott Wood
2011-10-06 23:35 ` Marek Vasut
2011-09-12 4:12 ` [U-Boot] [PATCH 0/2] SPL improvements Marek Vasut
2011-10-05 11:04 ` Marek Vasut
2011-10-05 19:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E73A848.2050500@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox