From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 16 Sep 2011 14:49:28 -0500 Subject: [U-Boot] [PATCH 2/2 RESEND] SPL: Allow user to disable CPU support library In-Reply-To: <201109160117.03992.marek.vasut@gmail.com> References: <1315800204-19705-1-git-send-email-marek.vasut@gmail.com> <1315800204-19705-3-git-send-email-marek.vasut@gmail.com> <4E7282E8.2000003@freescale.com> <201109160117.03992.marek.vasut@gmail.com> Message-ID: <4E73A848.2050500@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/15/2011 06:17 PM, Marek Vasut wrote: > On Friday, September 16, 2011 12:57:44 AM Scott Wood wrote: >> On 09/11/2011 11:03 PM, Marek Vasut wrote: >>> Introduce CONFIG_SPL_NO_CPU_SUPPORT_CODE to avoid compiling the CPU >>> support library. This can be useful on some setups. >>> >>> Signed-off-by: Marek Vasut >>> Cc: Stefano Babic >>> Cc: Wolfgang Denk >>> Cc: Detlev Zundel >>> Cc: Chander Kashyap >> >> But you didn't CC these... > > git send-email should handle those ? I'm not too familiar with git send-email, but they're not in the CC list of the actual e-mail. >>> +# In case we want to avoid the CPU support code, we need to define this: >>> +ifndef CONFIG_SPL_NO_CPU_SUPPORT_CODE >>> +SPL_CPU_SUPPORT_CODE := y >>> +endif >> >> SPL should ideally contain nothing by default. Have options that say >> what you do want to pull in, not what you don't want. > > You usually DO want to pull this in (because it contains vectoring code, really > basic lowlevel init etc), there are only border cases where you do not want to > do that and use your own. Sorry, I was a bit confused by seeing lib$(CPU), thought at first you were trying to pull in stuff like arch/$(ARCH)/lib. Still, this seems hackish. Shouldn't the control be on specific files that you include, not directories? -Scott