From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask
Date: Sun, 18 Sep 2011 02:48:36 +0400 [thread overview]
Message-ID: <4E7523C4.70709@mvista.com> (raw)
In-Reply-To: <20110916210108.079AB11F9E70@gemini.denx.de>
Hello.
On 17-09-2011 1:01, Wolfgang Denk wrote:
> Dear Sergei Shtylyov,
Thank you for the really quick response. :-)
>> MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix
>> the masks which previously was leaving out the intermediate state indicator bit.
>> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>> ---
>> Resending with the corrected subject/description...
>> Analogous Linux patch has been queued in the linux-davinci tree:
>> http://linux.davincidsp.com/pipermail/davinci-linux-open-source/2011-July/023075.html
>> arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S | 6 +++---
>> arch/arm/cpu/arm926ejs/davinci/psc.c | 4 ++--
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> Index: u-boot/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S
>> ===================================================================
>> --- u-boot.orig/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S
>> +++ u-boot/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S
>> @@ -268,7 +268,7 @@ checkStatClkStop:
>> checkDDRStatClkStop:
>> ldr r6, MDSTAT_DDR2
>> ldr r7, [r6]
>> - and r7, r7, $0x1f
>> + and r7, r7, $0x3f
> Don't you think it's high time to replace these magic constants with
> at least somewhat meaningful symbolic names (so it would be sufficient
> to fix this in a single place) ?
I agree. Do you mean I should recast this patch, or do two patches
instead: one adding the symbolic name and another correcting its value?
> Best regards,
> Wolfgang Denk
WBR, Sergei
next prev parent reply other threads:[~2011-09-17 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 14:54 [U-Boot] [PATCH] DaVinci: correct PDSTAT.STATE mask Sergei Shtylyov
2011-09-16 14:58 ` [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask Sergei Shtylyov
2011-09-16 21:01 ` Wolfgang Denk
2011-09-17 22:48 ` Sergei Shtylyov [this message]
2011-09-23 14:29 ` [U-Boot] [PATCH v3] " Sergei Shtylyov
2011-10-13 12:14 ` Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7523C4.70709@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox