From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 18 Sep 2011 02:48:36 +0400 Subject: [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask In-Reply-To: <20110916210108.079AB11F9E70@gemini.denx.de> References: <201109161854.38893.sshtylyov@ru.mvista.com> <201109161858.08706.sshtylyov@ru.mvista.com> <20110916210108.079AB11F9E70@gemini.denx.de> Message-ID: <4E7523C4.70709@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 17-09-2011 1:01, Wolfgang Denk wrote: > Dear Sergei Shtylyov, Thank you for the really quick response. :-) >> MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix >> the masks which previously was leaving out the intermediate state indicator bit. >> Signed-off-by: Sergei Shtylyov >> --- >> Resending with the corrected subject/description... >> Analogous Linux patch has been queued in the linux-davinci tree: >> http://linux.davincidsp.com/pipermail/davinci-linux-open-source/2011-July/023075.html >> arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S | 6 +++--- >> arch/arm/cpu/arm926ejs/davinci/psc.c | 4 ++-- >> 2 files changed, 5 insertions(+), 5 deletions(-) >> >> Index: u-boot/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S >> =================================================================== >> --- u-boot.orig/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S >> +++ u-boot/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S >> @@ -268,7 +268,7 @@ checkStatClkStop: >> checkDDRStatClkStop: >> ldr r6, MDSTAT_DDR2 >> ldr r7, [r6] >> - and r7, r7, $0x1f >> + and r7, r7, $0x3f > Don't you think it's high time to replace these magic constants with > at least somewhat meaningful symbolic names (so it would be sufficient > to fix this in a single place) ? I agree. Do you mean I should recast this patch, or do two patches instead: one adding the symbolic name and another correcting its value? > Best regards, > Wolfgang Denk WBR, Sergei