[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Fabio Estevam]

When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.

As the kernel has watchdog support, disable it from U-boot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx31pdk.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
index 1a5bdd1..e77805c 100644
--- a/include/configs/mx31pdk.h
+++ b/include/configs/mx31pdk.h
@@ -60,7 +60,6 @@
 
 #define CONFIG_MXC_UART
 #define CONFIG_SYS_MX31_UART1
-#define CONFIG_HW_WATCHDOG
 #define CONFIG_MXC_GPIO
 
 #define CONFIG_HARD_SPI
-- 
1.6.0.4

[U-Boot] [PATCH 2/2] mx31pdk: Change the prompt as per other i.MX boards

[Fabio Estevam]

Change the prompt as done in other i.MX boards.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx31pdk.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
index e77805c..7f91f67 100644
--- a/include/configs/mx31pdk.h
+++ b/include/configs/mx31pdk.h
@@ -123,7 +123,7 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"uboot> "
+#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \
-- 
1.6.0.4

[U-Boot] [PATCH 2/2] mx31pdk: Change the prompt as per other i.MX boards

[Stefano Babic]

On 09/16/2011 01:18 AM, Fabio Estevam wrote:
> Change the prompt as done in other i.MX boards.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx31pdk.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
> index e77805c..7f91f67 100644
> --- a/include/configs/mx31pdk.h
> +++ b/include/configs/mx31pdk.h
> @@ -123,7 +123,7 @@
>   * Miscellaneous configurable options
>   */
>  #define CONFIG_SYS_LONGHELP	/* undef to save memory */
> -#define CONFIG_SYS_PROMPT	"uboot> "
> +#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
>  #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
>  /* Print Buffer Size */
>  #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \

Acked-by : Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 2/2] mx31pdk: Change the prompt as per other i.MX boards

[Stefano Babic]

On 09/16/2011 01:18 AM, Fabio Estevam wrote:
> Change the prompt as done in other i.MX boards.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Hi Fabio,

>  include/configs/mx31pdk.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
> index e77805c..7f91f67 100644
> --- a/include/configs/mx31pdk.h
> +++ b/include/configs/mx31pdk.h
> @@ -123,7 +123,7 @@
>   * Miscellaneous configurable options
>   */
>  #define CONFIG_SYS_LONGHELP	/* undef to save memory */
> -#define CONFIG_SYS_PROMPT	"uboot> "
> +#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
>  #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
>  /* Print Buffer Size */
>  #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \

Applied to u-boot-imx, next branch, thanks.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Stefano Babic]

On 09/16/2011 01:18 AM, Fabio Estevam wrote:

Hi Fabio,

> When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.
> 
> As the kernel has watchdog support, disable it from U-boot.

But if the kernel has support for watchdog, why does the system reset ?
I checked this board and the watchdog in u-boot is set to 64 seconds,
that is the maximum value. It is surely enough for kernel to boot and to
start triggering the watchdog. If the system still reboots, it seems to
me that this is an issue to be fixed in kernel, not in u-boot. I am sure
I have tested in the past (not recently) the QONG board with enabled
watchdog, using also the imx2_wdt driver in kernel.

The watchdog in u-boot helps if u-boot hangs somewhere, for example
transfering the image from media. It is a different feature.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Fabio Estevam]

Hi Stefano,

On Fri, Sep 16, 2011 at 4:46 AM, Stefano Babic <sbabic@denx.de> wrote:
> On 09/16/2011 01:18 AM, Fabio Estevam wrote:
>
> Hi Fabio,
>
>> When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.
>>
>> As the kernel has watchdog support, disable it from U-boot.
>
> But if the kernel has support for watchdog, why does the system reset ?
> I checked this board and the watchdog in u-boot is set to 64 seconds,
> that is the maximum value. It is surely enough for kernel to boot and to
> start triggering the watchdog. If the system still reboots, it seems to
> me that this is an issue to be fixed in kernel, not in u-boot. I am sure
> I have tested in the past (not recently) the QONG board with enabled
> watchdog, using also the imx2_wdt driver in kernel.

I have sent a patch to the ARM kernel list to add watchdog support for
qong board:
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-September/065698.html

Can you please try it and let me know if you get resets when watchdog
is enabled in U-boot
and kernel?

Thanks,

Fabio Estevam

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Stefano Babic]

On 09/19/2011 05:04 PM, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Fri, Sep 16, 2011 at 4:46 AM, Stefano Babic <sbabic@denx.de> wrote:
>> On 09/16/2011 01:18 AM, Fabio Estevam wrote:
>>
>> Hi Fabio,
>>
>>> When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.
>>>
>>> As the kernel has watchdog support, disable it from U-boot.
>>
>> But if the kernel has support for watchdog, why does the system reset ?
>> I checked this board and the watchdog in u-boot is set to 64 seconds,
>> that is the maximum value. It is surely enough for kernel to boot and to
>> start triggering the watchdog. If the system still reboots, it seems to
>> me that this is an issue to be fixed in kernel, not in u-boot. I am sure
>> I have tested in the past (not recently) the QONG board with enabled
>> watchdog, using also the imx2_wdt driver in kernel.
> 
> I have sent a patch to the ARM kernel list to add watchdog support for
> qong board:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-September/065698.html

Ok, thanks.

> 
> Can you please try it and let me know if you get resets when watchdog
> is enabled in U-boot
> and kernel?

It works, the board does not get reset (of course, it is required to
trigger at least once the watchdog under the kernel). I send my
Tested-by to linux-arm.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Fabio Estevam]

On Mon, Sep 19, 2011 at 1:24 PM, Stefano Babic <sbabic@denx.de> wrote:
...
> It works, the board does not get reset (of course, it is required to
> trigger at least once the watchdog under the kernel). I send my
> Tested-by to linux-arm.

Yes, looks like on my mx31pdk the kernel never services the watchdog.

Will try to debug the kernel then.

Thanks for testing it on qong board.

Regards,

Fabio Estevam

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Fabio Estevam]

Hi Stefano,

On Mon, Sep 19, 2011 at 1:57 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Sep 19, 2011 at 1:24 PM, Stefano Babic <sbabic@denx.de> wrote:
> ...
>> It works, the board does not get reset (of course, it is required to
>> trigger at least once the watchdog under the kernel). I send my
>> Tested-by to linux-arm.

I managed to fix this and will submit a patch for U-boot shortly.

Regards,

Fabio Estevam

[U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

[Sergei Shtylyov]

Hello.

On 16-09-2011 3:18, Fabio Estevam wrote:

> When booting a mainline kernel on a mx31pdk the system gets getting resets from the watchdog.

    That's tautological. Maybe "is getting reset"?

> As the kernel has watchdog support, disable it from U-boot.

> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>

WBR, Sergei