[U-Boot] [PATCH] MX31: Disable watchdog during low-power modes

Stefano Babic
2011-09-21T05:24:38Z

On 09/21/2011 05:43 AM, Fabio Estevam wrote:
> Hi Stefano and Marek,

Hi Fabio,

>
> On Tue, Sep 20, 2011 at 5:48 AM, Stefano Babic <sbabic@denx.de> wrote:
> ...
>>> Maybe
>>> tmp = readw();
>>> tmp |= ...
>>> writel(tmp, ...);
>>
>> Well, I do not see a big difference with your proposal - so it is only a
>> question of taste. Calling write with an embedded read as first
>> parameter is used often in u-boot.
>
> Have we reached an agreement on whether I should change my original
> patch or if it is fine as is?

IMHO I can push your patch as it is. Your change uses the same style as
in the current file, setting only a further bit.

>
> If I need to change it, please let me know how you prefer it.
>
> I am fine either way, but really want to stop my MX31PDK to get
> watchdog resets all the time ;-)

I can understand...

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================