public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 RESEND] SPL: Allow user to disable CPU support library
Date: Tue, 20 Sep 2011 16:23:01 -0500	[thread overview]
Message-ID: <4E790435.1090703@freescale.com> (raw)
In-Reply-To: <201109202316.04328.marek.vasut@gmail.com>

On 09/20/2011 04:16 PM, Marek Vasut wrote:
> On Tuesday, September 20, 2011 09:12:08 PM Scott Wood wrote:
>> On 09/19/2011 05:31 PM, Marek Vasut wrote:
>>> Then you adjust the makefile there by ifdef CONFIG_SPL_BUILD
>>
>> It's not quite that simple, since different SPLs will have different
>> requirements.  Board config headers will need to define symbols like
>> CONFIG_SPL_FEATURE and the makefiles will use both CONFIG_SPL_BUILD and
>> CONFIG_SPL_FEATURE to determine which object files to include.
> 
> That kind of granularity is there already too -- though on driver level. But so 
> far it seem sufficient.

What's wrong with using that model for arch code as well?

Note that "so far" most of the existing SPL targets have not been
converted to the new spl/.

>>>> Whether it's file or directory based, everything should be off by
>>>> default.  Boards should ask for what they want, not what they want to
>>>> exclude.
>>>
>>> Actually, this being a rare case where you want it excluded, it's better
>>> the way it is.
>>
>> I disagree, especially in the early stages where we're setting an
>> example for how other components will be handled.
> 
> No, it's really rare if you want to replace your lowlevel init code because your 
> ROM seems strange.

It's not about rarity (which is often misjudged, BTW).  It's about
whether the model for selecting code for the SPL is additive or
subtractive, and whether we have a consistent mechanism or ad hockery
from the start.

In nand_spl/ it was fully additive.  I'd like to keep it that way.

-Scott

  reply	other threads:[~2011-09-20 21:23 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-12  4:03 [U-Boot] [PATCH 0/2] SPL improvements Marek Vasut
2011-09-12  4:03 ` [U-Boot] [PATCH 1/2 RESEND] SPL: Make path to start.S configurable Marek Vasut
2011-10-05 19:08   ` Wolfgang Denk
2011-10-05 20:07     ` Wolfgang Denk
2011-10-05 20:15       ` Wolfgang Denk
2011-09-12  4:03 ` [U-Boot] [PATCH 2/2 RESEND] SPL: Allow user to disable CPU support library Marek Vasut
2011-09-15 22:57   ` Scott Wood
2011-09-15 23:17     ` Marek Vasut
2011-09-16 19:49       ` Scott Wood
2011-09-16 21:38         ` Marek Vasut
2011-09-16 21:42           ` Scott Wood
2011-09-16 21:47             ` Marek Vasut
2011-09-16 22:07               ` Scott Wood
2011-09-16 22:48                 ` Marek Vasut
2011-09-19 18:13                   ` Scott Wood
2011-09-19 22:31                     ` Marek Vasut
2011-09-20 19:12                       ` Scott Wood
2011-09-20 21:16                         ` Marek Vasut
2011-09-20 21:23                           ` Scott Wood [this message]
2011-09-20 21:30                             ` Marek Vasut
2011-09-20 23:31                               ` Scott Wood
2011-09-22  8:52                                 ` Marek Vasut
2011-10-05 21:44                                   ` Tom Rini
2011-10-05 22:02                                     ` Scott Wood
2011-10-05 22:20                                       ` Marek Vasut
2011-10-06  0:13   ` [U-Boot] [PATCH 1/2] " Marek Vasut
2011-10-06  0:13     ` [U-Boot] [PATCH 2/2] SPL: Allow ARM926EJS to avoid compiling in the CPU support code Marek Vasut
2011-10-18 21:33       ` Albert ARIBAUD
2011-10-18 22:30         ` Marek Vasut
2011-10-21 20:44       ` Marek Vasut
2011-10-21 21:52         ` Albert ARIBAUD
2011-10-21 22:00           ` Marek Vasut
2011-10-21 22:44             ` Albert ARIBAUD
2011-10-21 22:46               ` Marek Vasut
2011-10-21 23:08                 ` Albert ARIBAUD
2011-10-21 23:45                   ` Marek Vasut
2011-10-22  0:04                     ` Tom Rini
2011-10-22  0:19                       ` Marek Vasut
2011-10-22  0:41                         ` Albert ARIBAUD
2011-10-22  1:20                           ` Marek Vasut
2011-10-22  7:05                             ` Albert ARIBAUD
2011-10-24 10:14       ` [U-Boot] [PATCH 2/2 V2] " Marek Vasut
2011-11-03  0:05         ` Marek Vasut
2011-11-04 13:59           ` Marek Vasut
2011-11-08 21:15         ` Albert ARIBAUD
2011-10-06 15:54     ` [U-Boot] [PATCH 1/2] SPL: Allow user to disable CPU support library Scott Wood
2011-10-06 23:35       ` Marek Vasut
2011-09-12  4:12 ` [U-Boot] [PATCH 0/2] SPL improvements Marek Vasut
2011-10-05 11:04 ` Marek Vasut
2011-10-05 19:14   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E790435.1090703@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox