From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MX31: Disable watchdog during low-power modes
Date: Wed, 21 Sep 2011 07:24:38 +0200 [thread overview]
Message-ID: <4E797516.7000503@denx.de> (raw)
In-Reply-To: <CAOMZO5Do_W8FX6Qyihy8_bwu6XPoCZ=VKOdU54GvpF7p=CkJBw@mail.gmail.com>
On 09/21/2011 05:43 AM, Fabio Estevam wrote:
> Hi Stefano and Marek,
Hi Fabio,
>
> On Tue, Sep 20, 2011 at 5:48 AM, Stefano Babic <sbabic@denx.de> wrote:
> ...
>>> Maybe
>>> tmp = readw();
>>> tmp |= ...
>>> writel(tmp, ...);
>>
>> Well, I do not see a big difference with your proposal - so it is only a
>> question of taste. Calling write with an embedded read as first
>> parameter is used often in u-boot.
>
> Have we reached an agreement on whether I should change my original
> patch or if it is fine as is?
IMHO I can push your patch as it is. Your change uses the same style as
in the current file, setting only a further bit.
>
> If I need to change it, please let me know how you prefer it.
>
> I am fine either way, but really want to stop my MX31PDK to get
> watchdog resets all the time ;-)
I can understand...
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-09-21 5:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 17:51 [U-Boot] [PATCH] MX31: Disable watchdog during low-power modes Fabio Estevam
2011-09-20 4:16 ` Marek Vasut
2011-09-20 8:48 ` Stefano Babic
2011-09-20 9:24 ` Marek Vasut
2011-09-21 3:43 ` Fabio Estevam
2011-09-21 5:24 ` Stefano Babic [this message]
2011-09-21 6:26 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E797516.7000503@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox