From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 21 Sep 2011 07:24:38 +0200 Subject: [U-Boot] [PATCH] MX31: Disable watchdog during low-power modes In-Reply-To: References: <1316454670-31278-1-git-send-email-fabio.estevam@freescale.com> <201109200616.59531.marek.vasut@gmail.com> <4E78534C.3080604@denx.de> Message-ID: <4E797516.7000503@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/21/2011 05:43 AM, Fabio Estevam wrote: > Hi Stefano and Marek, Hi Fabio, > > On Tue, Sep 20, 2011 at 5:48 AM, Stefano Babic wrote: > ... >>> Maybe >>> tmp = readw(); >>> tmp |= ... >>> writel(tmp, ...); >> >> Well, I do not see a big difference with your proposal - so it is only a >> question of taste. Calling write with an embedded read as first >> parameter is used often in u-boot. > > Have we reached an agreement on whether I should change my original > patch or if it is fine as is? IMHO I can push your patch as it is. Your change uses the same style as in the current file, setting only a further bit. > > If I need to change it, please let me know how you prefer it. > > I am fine either way, but really want to stop my MX31PDK to get > watchdog resets all the time ;-) I can understand... Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================