From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Schwarz Date: Wed, 21 Sep 2011 11:13:41 +0200 Subject: [U-Boot] SMDK6400 regression In-Reply-To: <4E7836F4.7000903@aribaud.net> References: <1316389174-31117-1-git-send-email-s-paulraj@ti.com> <4E76EBFD.9060505@aribaud.net> <20110919074710.D0CAD1407967@gemini.denx.de> <4E773165.1090304@aribaud.net> <4E7836F4.7000903@aribaud.net> Message-ID: <4E79AAC5.9000803@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/20/2011 08:47 AM, Albert ARIBAUD wrote: > Copying Simon as the author of the commit, in order to confirm that the > issue is in smdk6400. The problem is that I added a nand_read_buf prototype in nand.h this was defined static in nand_base.c - I removed the static declaration. smdk6400 is defining the exact same functions in its SPL but they are static. Dublicated code like this was the reason for my changes. I can provide a quickfix by just remove the static from the smdk6400-functions. But IMHO it is more sensible to write a proper header for most of the functions in nand_base.c and remove the static modifier. Then they can be used in SPLs and no one tries to redo/copy them again. Scott what's your opinion on that? Regards Simon