From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Aldridge Date: Wed, 21 Sep 2011 10:27:37 +0100 Subject: [U-Boot] [PATCH v4] ns16550: change to allow 32 bit access to registers In-Reply-To: <20110907213623.08733140875D@gemini.denx.de> References: <1314953234-3977-1-git-send-email-fovsoft@gmail.com> <20110907213623.08733140875D@gemini.denx.de> Message-ID: <4E79AE09.1030301@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang On 07/09/11 22:36, Wolfgang Denk wrote: > Dear Dave Aldridge, > > In message <1314953234-3977-1-git-send-email-fovsoft@gmail.com> you wrote: >> If CONFIG_SYS_NS16550_MEM32 is defined then 32 bit memory >> mapped access will be used to read/write the uart registers. > ... >> +#elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE > 0) >> +#define serial_out(x,y) out_be32(y,x) >> +#define serial_in(y) in_be32(y) >> +#elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE < 0) > > Please see comment to previous version. I think the discussions in the '[U-Boot] [PATCH v3] ns16550:' confirm the above usage of the _REG_SIZE macro for determining the endianess of the uart is correct. I can also confirm that the patch does work for me. Cheers Dave