[U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

Michal Simek
2011-09-21T12:21:35Z

Marek Vasut wrote:
> On Tuesday, September 20, 2011 09:19:23 AM Michal Simek wrote:
>> Michal Simek wrote:
>>> Add support for SERIAL MULTI for uartlite.
>>>
>>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>>>
>>> ---
>>> v2: Use in/out_be32 functions
>>>
>>> v3: Clean coding style
>>>
>>> v4: Simplify userial_ports array initialization
>>> ---
>>>
>>> common/serial.c | 14 ++++
>>> drivers/serial/serial_xuartlite.c | 134
>>> ++++++++++++++++++++++++++++++++----- include/serial.h
>>> | 7 ++
>>> 3 files changed, 137 insertions(+), 18 deletions(-)
>> Any comment?
>
> Avoid endless loops

No problem to do it for putc but for getc?
What would you like to return if there is no character available?

If generic code always checked if there is any character available through tstc
and then call getc I can keep there just reading buffer but from my test I see that
it doesn't do that.

Please point me to any existing u-boot serial driver which does it in way you like.
I wasn't able to find it out.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian