public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] OMAP3: beagle: Fix build warning in beagle.c
@ 2011-09-22 11:53 Dirk Behme
  2011-09-22 12:41 ` Jason Kridner
  2011-09-22 16:02 ` Albert ARIBAUD
  0 siblings, 2 replies; 3+ messages in thread
From: Dirk Behme @ 2011-09-22 11:53 UTC (permalink / raw)
  To: u-boot

From: Dirk Behme <dirk.behme@googlemail.com>

Fix build warning

beagle.c:532: warning: initialization from incompatible pointer type

Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Koen Kooi <koen@dominion.thruhere.net>
CC: Joel A Fernandes <agnel.joel@gmail.com>
Cc: Greg Turner <gregturner@ti.com>
CC: Sandeep Paulraj <s-paulraj@ti.com>

---
Note: This seems to be introduced with the commit

"BeagleBoard: Added userbutton command"

http://git.denx.de/?p=u-boot.git;a=commit;h=f835ea7158025818d69384a7ebd8c3de0f10a9f7

 board/ti/beagle/beagle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: u-boot.git/board/ti/beagle/beagle.c
===================================================================
--- u-boot.git.orig/board/ti/beagle/beagle.c
+++ u-boot.git/board/ti/beagle/beagle.c
@@ -486,7 +486,7 @@ int ehci_hcd_init(void)
  * Returns - 	1 if button is held down
  *		0 if button is not held down
  */
-int do_userbutton (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+int do_userbutton(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	int     button = 0;
 	int	gpio;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] OMAP3: beagle: Fix build warning in beagle.c
  2011-09-22 11:53 [U-Boot] [PATCH] OMAP3: beagle: Fix build warning in beagle.c Dirk Behme
@ 2011-09-22 12:41 ` Jason Kridner
  2011-09-22 16:02 ` Albert ARIBAUD
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Kridner @ 2011-09-22 12:41 UTC (permalink / raw)
  To: u-boot

On Thu, Sep 22, 2011 at 7:53 AM, Dirk Behme <dirk.behme@googlemail.com> wrote:
> From: Dirk Behme <dirk.behme@googlemail.com>
>
> Fix build warning
>
> beagle.c:532: warning: initialization from incompatible pointer type
>
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
> CC: Jason Kridner <jkridner@beagleboard.org>

Acked-by: Jason Kridner <jkridner@beagleboard.org>

> CC: Koen Kooi <koen@dominion.thruhere.net>
> CC: Joel A Fernandes <agnel.joel@gmail.com>
> Cc: Greg Turner <gregturner@ti.com>
> CC: Sandeep Paulraj <s-paulraj@ti.com>
>
> ---
> Note: This seems to be introduced with the commit
>
> "BeagleBoard: Added userbutton command"
>
> http://git.denx.de/?p=u-boot.git;a=commit;h=f835ea7158025818d69384a7ebd8c3de0f10a9f7
>
> ?board/ti/beagle/beagle.c | ? ?2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: u-boot.git/board/ti/beagle/beagle.c
> ===================================================================
> --- u-boot.git.orig/board/ti/beagle/beagle.c
> +++ u-boot.git/board/ti/beagle/beagle.c
> @@ -486,7 +486,7 @@ int ehci_hcd_init(void)
> ?* Returns - ? 1 if button is held down
> ?* ? ? ? ? ? ? 0 if button is not held down
> ?*/
> -int do_userbutton (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +int do_userbutton(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> ?{
> ? ? ? ?int ? ? button = 0;
> ? ? ? ?int ? ? gpio;
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] OMAP3: beagle: Fix build warning in beagle.c
  2011-09-22 11:53 [U-Boot] [PATCH] OMAP3: beagle: Fix build warning in beagle.c Dirk Behme
  2011-09-22 12:41 ` Jason Kridner
@ 2011-09-22 16:02 ` Albert ARIBAUD
  1 sibling, 0 replies; 3+ messages in thread
From: Albert ARIBAUD @ 2011-09-22 16:02 UTC (permalink / raw)
  To: u-boot

Hi Dirk,

Le 22/09/2011 13:53, Dirk Behme a ?crit :
> From: Dirk Behme<dirk.behme@googlemail.com>
>
> Fix build warning
>
> beagle.c:532: warning: initialization from incompatible pointer type
>
> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
> CC: Jason Kridner<jkridner@beagleboard.org>
> CC: Koen Kooi<koen@dominion.thruhere.net>
> CC: Joel A Fernandes<agnel.joel@gmail.com>
> Cc: Greg Turner<gregturner@ti.com>
> CC: Sandeep Paulraj<s-paulraj@ti.com>
>
> ---

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-09-22 16:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-22 11:53 [U-Boot] [PATCH] OMAP3: beagle: Fix build warning in beagle.c Dirk Behme
2011-09-22 12:41 ` Jason Kridner
2011-09-22 16:02 ` Albert ARIBAUD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox