From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 23 Sep 2011 16:23:04 +0200 Subject: [U-Boot] [PATCH v2] zmx25: Fix build warning due to 'get_reset_cause' defined but not used In-Reply-To: <1316787411-11758-1-git-send-email-fabio.estevam@freescale.com> References: <1316787411-11758-1-git-send-email-fabio.estevam@freescale.com> Message-ID: <4E7C9648.5050500@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/23/2011 04:16 PM, Fabio Estevam wrote: > When building the zmx25 target we get: > > Configuring for zmx25 board... > generic.c:108: warning: 'get_reset_cause' defined but not used > > Fix this warning by defining get_reset_cause only if CONFIG_DISPLAY_CPUINFO is defined. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > > - Only define get_reset_cause when CONFIG_DISPLAY_CPUINFO is defined. > > arch/arm/cpu/arm926ejs/mx25/generic.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/cpu/arm926ejs/mx25/generic.c b/arch/arm/cpu/arm926ejs/mx25/generic.c > index 1261640..91b04c1 100644 > --- a/arch/arm/cpu/arm926ejs/mx25/generic.c > +++ b/arch/arm/cpu/arm926ejs/mx25/generic.c > @@ -105,6 +105,7 @@ ulong imx_get_perclk (int clk) > return lldiv (fref, div); > } > > +#if defined(CONFIG_DISPLAY_CPUINFO) > static char *get_reset_cause(void) > { > /* read RCSR register from CCM module */ > @@ -127,6 +128,7 @@ static char *get_reset_cause(void) > return "unknown reset"; > > } > +#endif > I know it does not change how it works...but should be not better to move the get_reset_cause() function where the CONFIG_DISPLAY_CPUINFO is already active ? I mean, before the print_cpuinfo() function ? This enforces that the two functions are not disjuncted. I know this is only a question of taste, what do you think about it ? Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================