From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Thompson Date: Mon, 26 Sep 2011 10:26:51 +0100 Subject: [U-Boot] [PATCH] GCC4.4: Squash multiple warnings due to strict aliasing In-Reply-To: <1317002798-27112-1-git-send-email-marek.vasut@gmail.com> References: <1317002798-27112-1-git-send-email-marek.vasut@gmail.com> Message-ID: <4E80455B.4040602@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 26/09/11 03:06, Marek Vasut wrote: > Signed-off-by: Marek Vasut > --- > arch/arm/include/asm/io.h | 30 ++++++++++++++++++------------ > 1 files changed, 18 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > index 1fbc531..61f4987 100644 > --- a/arch/arm/include/asm/io.h > +++ b/arch/arm/include/asm/io.h > @@ -78,43 +78,49 @@ static inline phys_addr_t virt_to_phys(void * vaddr) > extern inline void __raw_writesb(unsigned int addr, const void *data, int bytelen) > { > uint8_t *buf = (uint8_t *)data; > - while(bytelen--) > - __arch_putb(*buf++, addr); > + int i; > + for (i = 0; i < bytelen; i++) > + __arch_putb(buf[i], addr); > } > This fixes the problem in these use cases, but leaves the door open. Would it be better to change the __arch_putb macro into an extern inline function instead which would catch these and future cases? Nick.