From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Brunck Date: Mon, 26 Sep 2011 18:40:17 +0200 Subject: [U-Boot] [PATCH] net/eth: add newline to "failed MAC address" warning In-Reply-To: <201109261207.25045.vapier@gentoo.org> References: <1316782071-8988-1-git-send-email-holger.brunck@keymile.com> <4E808B36.6020404@balister.org> <201109261207.25045.vapier@gentoo.org> Message-ID: <4E80AAF1.9090906@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/26/2011 06:07 PM, Mike Frysinger wrote: > On Monday, September 26, 2011 10:24:54 Philip Balister wrote: >> On 09/23/2011 08:47 AM, Holger Brunck wrote: >>> This prevents u-boot to display during bootime: >>> Out: serial >>> Err: serial >>> Net: UEC3Warning: failed to set MAC address >>> >>> Now corrected and it will display: >>> Out: serial >>> Err: serial >>> Net: UEC3 >>> Warning: failed to set MAC address >>> >>> Signed-off-by: Holger Brunck >> >> Acked-by: Philip Balister >> >> But, when i submitted the same patch, I was told this is not the right >> way to solve the problem. I would still like to see this patch go in >> until someone has time to rewrite the problem section of code. > > i don't think it is the right way long term, but short term, i think it's > correct wrt the surrounding code. Yes I agree. It never meant to be more than a bootlog improvement. The root cause should be fixed in the long term. Regards Holger