From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Date: Mon, 26 Sep 2011 22:24:27 +0300 Subject: [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines In-Reply-To: <20110923060634.50D2F140797A@gemini.denx.de> References: <1315243448-29959-1-git-send-email-vz@mleia.com> <1315243448-29959-3-git-send-email-vz@mleia.com> <20110923060634.50D2F140797A@gemini.denx.de> Message-ID: <4E80D16B.8060107@mleia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, On 23.09.2011 09:06, Wolfgang Denk wrote: > Dear Andy Fleming, > > In message you wrote: >> >> Shoot, I just saw this patch in my tree. It's incorrect. > > Argh... > >> The lines weren't redundant. The logic is (and probably should be >> better commented): >> >> Find the intersection of the advertised capabilities of both sides of >> the link (lpa) >> From that intersection, find the highest capability we can run at >> (that will be the negotiated link) >> >> Now imagine that the intersection (lpa) is (LPA_100HALF | LPA_10FULL). >> >> The code will now set phydev->speed to 100, and phydev->duplex to 1, >> but this link does not support 100FULL. > > Do we agree that I should revert this commit? > due to Andy's explanation I agree that this change is fishy and it should be reverted. As a U-Boot user I'd greatly appreciate, if you add the above note to the commit message. Sorry for inconvenience. -- With best wishes, Vladimir