From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Thompson <nick.thompson@ge.com>
Date: Tue, 27 Sep 2011 09:59:55 +0100
Subject: [U-Boot] [PATCH] ARM: Convert {in,
	out}s[bwl] to inline functions
In-Reply-To: <1317062895-3847-1-git-send-email-marek.vasut@gmail.com>
References: <1317062895-3847-1-git-send-email-marek.vasut@gmail.com>
Message-ID: <4E81908B.1050503@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 26/09/11 19:48, Marek Vasut wrote:
> The size of uboot binary grows by a few bytes, but the gain (better type
> checking) is worth it.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Nick Thompson <nick.thompson@ge.com>
> Cc: Simon Glass <sjg@chromium.org>

Do you want to cc: Albert ARIBAUD <albert.u.boot@aribaud.net> as well?

> ---
>  arch/arm/include/asm/io.h |   34 ++++++++++++++++++++++++++++------
>  1 files changed, 28 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index 61f4987..d22325d 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
> @@ -255,13 +255,35 @@ extern inline void __raw_readsl(unsigned int addr, void *data, int longlen)
>  #define inw(p)	({ unsigned int __v = le16_to_cpu(__raw_readw(__io(p))); __v; })
>  #define inl(p)	({ unsigned int __v = le32_to_cpu(__raw_readl(__io(p))); __v; })
>  
> -#define outsb(p,d,l)			__raw_writesb(__io(p),d,l)
> -#define outsw(p,d,l)			__raw_writesw(__io(p),d,l)
> -#define outsl(p,d,l)			__raw_writesl(__io(p),d,l)

These changes are clearly related, but we started out talking about '__arch_putb',
which is in the same file of course. Did I miss something?

This specific patch looks reasonable to me though.

Reviewed-by: Nick Thompson <nick.thompson@ge.com>

> +extern inline void outsb(unsigned int addr, const void *data, int bytelen)
> +{
> +	__raw_writesb(addr, data, bytelen);
> +}
> +
> +extern inline void outsw(unsigned int addr, const void *data, int wordlen)
> +{
> +	__raw_writesw(addr, data, wordlen);
> +}
> +
> +extern inline void outsl(unsigned int addr, const void *data, int longlen)
> +{
> +	__raw_writesl(addr, data, longlen);
> +}
>  
> -#define insb(p,d,l)			__raw_readsb(__io(p),d,l)
> -#define insw(p,d,l)			__raw_readsw(__io(p),d,l)
> -#define insl(p,d,l)			__raw_readsl(__io(p),d,l)
> +extern inline void insb(unsigned int addr, void *data, int bytelen)
> +{
> +	__raw_readsb(addr, data, bytelen);
> +}
> +
> +extern inline void insw(unsigned int addr, void *data, int wordlen)
> +{
> +	__raw_readsw(addr, data, wordlen);
> +}
> +
> +extern inline void insl(unsigned int addr, void *data, int longlen)
> +{
> +	__raw_readsl(addr, data, longlen);
> +}
>  #endif
>  
>  #define outb_p(val,port)		outb((val),(port))