From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 27 Sep 2011 14:51:09 -0500 Subject: [U-Boot] [PATCH 4/5 V2] NAND: Make page, erase, oob size available via cmd_nand In-Reply-To: <201109272138.59945.marek.vasut@gmail.com> References: <1315800250-19761-5-git-send-email-marek.vasut@gmail.com> <1316656646-8338-1-git-send-email-marek.vasut@gmail.com> <20110927190153.GC10082@schlenkerla.am.freescale.net> <201109272138.59945.marek.vasut@gmail.com> Message-ID: <4E82292D.2090504@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/27/2011 02:38 PM, Marek Vasut wrote: > On Tuesday, September 27, 2011 09:01:53 PM Scott Wood wrote: >> On Thu, Sep 22, 2011 at 03:57:26AM +0200, Marek Vasut wrote: >>> + /* Set geometry info */ >>> + memset(buf, 0, bufsz); >>> + sprintf(buf, "%x", nand->writesize); >>> + setenv("nand_writesize", buf); >>> + >>> + memset(buf, 0, bufsz); >>> + sprintf(buf, "%x", nand->oobsize); >>> + setenv("nand_oobsize", buf); >>> + >>> + memset(buf, 0, bufsz); >>> + sprintf(buf, "%x", nand->erasesize); >>> + setenv("nand_erasesize", buf); >> >> Why the memsets? > > To clear the memory from previous usage ? What part of the previous usage will both survive the sprintf() and be looked at by setenv()? -Scott