public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] env: set individual variables to default
Date: Thu, 29 Sep 2011 08:13:09 +0200	[thread overview]
Message-ID: <4E840C75.7080905@keymile.com> (raw)
In-Reply-To: <20110928210809.79CA6140799B@gemini.denx.de>

On 09/28/2011 11:08 PM, Wolfgang Denk wrote:
> Dear Gerlando Falauto,
>
> In message<4E82E6CA.9030802@keymile.com>  you wrote:
>>
>>> env import -n name[,..] [other_flags] addr [size]
>>>
>>> ?
>>
>> Uhm, wouldn't that make the syntax completely unrelated to all other
>> commands, leading to confusion?
>>
>> How about something like:
>>
>> env import [-f] [flags] addr [size] [-n name[ ...]]
>> env default [-f] -a|-n name[ ...]
>> env set [-f] name [val ...]
>
> No.  That's even worse.

You mean that options should always precede the main argument?

> If you don't like the comma separation,we
> could as well accept multiple -n args:
>
> env import -n name [-n name1 ... ] [other_flags] addr [size]

It's not that I don't like comma separation. It's just that maybe the 
syntax should be consistent between commands... that's all.
But since it's a very unusual (and possibly unused) command, I am 
probably worrying too much.

>> Where:
>>    -a in "env default" would be the way to prevent the inadverent user
>>       from wrecking the environment by mistake.
>
> What does -a stand for?  "all" ?

Yes. Any comments on this?
How should we implement "env default" for the whole env?
1) "env default"
2) "env deafult -a"
3) "env default all"

>> Slightly off-topic: how about variables starting with "-"?
>
> Should be no problem in general, except for the pathological cases
> like variable names "-f" etc.   But there has to be a penalty for such
> stupid names :-)

I can't think of any shell or programming language allowing for 
variables starting with "-" or digits...

Thasnks,
Gerlando Falauto

  reply	other threads:[~2011-09-29  6:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 15:06 [U-Boot] [PATCH 0/2] implement set individual variables to default Gerlando Falauto
2011-09-22 15:06 ` [U-Boot] [PATCH 1/2] env: " Gerlando Falauto
2011-09-22 19:51   ` Wolfgang Denk
2011-09-23  7:31     ` Gerlando Falauto
2011-09-23  9:55       ` Wolfgang Denk
2011-09-28  9:20         ` Gerlando Falauto
2011-09-28 21:08           ` Wolfgang Denk
2011-09-29  6:13             ` Gerlando Falauto [this message]
2011-09-22 15:06 ` [U-Boot] [PATCH 2/2] km/common: enable "env default" for all keymile boards Gerlando Falauto
2011-10-21 22:37   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E840C75.7080905@keymile.com \
    --to=gerlando.falauto@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox