[U-Boot] [PATCH] mx31: provide readable WEIM CS accessor

Helmut Raiger
2011-09-29T07:30:49Z

On 09/28/2011 05:14 PM, Stefano Babic wrote:
>> +#ifndef __ASSEMBLER__
>> +static inline void mx31_setup_weimcs(int cs,
> Is there a reason to embed this function in imx-regs.h ? Why not in
> ./arch/arm/cpu/arm1136/mx31/generic.c, where I think this function
> belongs ?
>

I re-checked, it makes a lot of sense to inline this function as it
results into 3 simple register writes (addresses are compile time
calculated if 'cs' is a constant)!

Helmut

--
Scanned by MailScanner.