[U-Boot] [PATCH V2 3/3] mx31: Add board support for HALE TT-01

Wolfgang Denk
2011-10-14T21:14:47Z

Dear Stefano Babic,

In message <4E981741.6050809@denx.de> you wrote:
>
> > + while (wait--) ;

Checkpatch is supposed to complain about this; the semicolon goes on
the next line.

>
> I had the same problem - a udelay() before relocation.

This should be no problem. udelay() is supposed to work fine very
early - ling before relocation.

> However, there is a sdelay() in armv7 (syslib.c), and I sent a patch to
> move this stuff into arm/lib to make this and the other functions
> available to all ARM SOCs

What the hell is sdelay()?

Please let us not introduce arbitrary new functions without need.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brontosaurus Principle: Organizations can grow faster than their
brains can manage them in relation to their environment and to their
own physiology: when this occurs, they are an endangered species.
- Thomas K. Connellan