[U-Boot] [PATCH V2 3/3] mx31: Add board support for HALE TT-01

Wolfgang Denk
2011-10-15T08:52:48Z

Dear stefano babic,

In message <4E991CC3.5010205@denx.de> you wrote:
>
> > This should be no problem. udelay() is supposed to work fine very
> > early - ling before relocation.
>
> Maybe I should be more clearer - we need a way to wait some time when
> even PLL or clock module (for i.MX) are not yet programmed.

> > What the hell is sdelay()?
> >
> > Please let us not introduce arbitrary new functions without need.
>
> This is *not* a new function. I see it was introduced for OMAP3 since a
> lot of time ago. I do not want to introduce another function, I will
> reuse what is already available for other SOCs.

The fact that some private function was allowed (or rather not
objected durign the reviews) for s specific implementation does not
mean that it is a good idea to generalize this code for other boards
or architectures - if we do something like that, we should discuss it
first, and put it in context with the (Not yet complete) discussion
about the new Timer API.

I definitely do not want to see this function spread uncontrolled and
undiscussed. If we find it's useful, it should be made really
general.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Imagination is more important than knowledge. -- Albert Einstein