From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 8/8] arm, davinci: add support for am1808 based enbw_cmc board
Date: Fri, 30 Sep 2011 10:46:55 +0200 [thread overview]
Message-ID: <4E8581FF.3020507@denx.de> (raw)
In-Reply-To: <CABkLObrOGF2mcHW0H+2rUwsnX7W9zYnKprHWgUHZS1YvttJebA@mail.gmail.com>
Hello Christian,
Christian Riesch wrote:
> Hello Heiko,
>
> On Mon, Sep 19, 2011 at 7:50 AM, Heiko Schocher <hs@denx.de> wrote:
>> - booting from NOR Flash with direct boot method
>> - POST support
>> - LOGBUF support
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Cc: Paulraj Sandeep <s-paulraj@ti.com>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>> - changes for v2
>> - use CONFIG_MACH_TYPE instead setting the MACH_TYPE in
>> board specific code, as Igor Grinberg suggested.
>> - add logversion=2 to default Environment
>>
>> board/enbw/enbw_cmc/Makefile | 51 ++++
>> board/enbw/enbw_cmc/enbw_cmc.c | 570 ++++++++++++++++++++++++++++++++++++++++
>> boards.cfg | 1 +
>> include/configs/enbw_cmc.h | 443 +++++++++++++++++++++++++++++++
>> 4 files changed, 1065 insertions(+), 0 deletions(-)
>> create mode 100644 board/enbw/enbw_cmc/Makefile
>> create mode 100644 board/enbw/enbw_cmc/enbw_cmc.c
>> create mode 100644 include/configs/enbw_cmc.h
>
> [...]
>
>> diff --git a/include/configs/enbw_cmc.h b/include/configs/enbw_cmc.h
>> new file mode 100644
>> index 0000000..e203089
>> --- /dev/null
>> +++ b/include/configs/enbw_cmc.h
>
> [...]
>
>> +#define CONFIG_SYS_AM1808_PLL0_PLLM 37 /* PLL0 -> 456 MHz */
>
> With a 24 MHz input frequency this would result in a PLL0 frequency of
> 24MHz / PREDIV * (CONFIG_SYS_AM1808_PLL0_PLLM + 1), so I guess you
> assume a PREDIV of 2 here (PREDIV register value 0x00008001). However,
No. The comment is wrong! I fix the comment from PLL0 to PLLC0
in the next patch version, thanks!
> the AM1808 datasheet and the reference guide (section 7.3.10) state
> that the default PREDIV is 1 (register value 0x00008000) and I don't
> see how you set the PREDIV to 2. Am I missing something here?
For calculating the resulting frequencies for the used Sysclocks
don;t forget the POSTDIV value
#define CONFIG_SYS_AM1808_PLL0_POSTDIV 1
So the correct calculation is:
(24MHz / PREDIV * (CONFIG_SYS_AM1808_PLL0_PLLM + 1)) / POSTDIV
(And with that, I get 456 MHz ;-)
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-09-30 8:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 5:59 [U-Boot] [PATCH 0/8] arm, davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 1/8] arm, davinci: add SYSCFG1 base and register struct Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 2/8] arm, davinci: add some missing defines in hardware.h Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 3/8] arm, davinci, am1808, gpio: add missing defines for bank 8 Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 4/8] arm, davinci: add ddr2 definition Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 5/8] arm, davinci: add NOR Boot Configuration Word Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 6/8] arm, davinci, am1808: add lowlevel functions for booting from NOR Heiko Schocher
2011-09-26 8:02 ` Christian Riesch
2011-09-26 8:28 ` Heiko Schocher
2011-09-27 6:57 ` Christian Riesch
2011-09-27 7:27 ` Heiko Schocher
2011-09-27 8:37 ` Christian Riesch
2011-09-27 8:50 ` Heiko Schocher
2011-09-27 10:36 ` Christian Riesch
2011-09-27 11:18 ` Heiko Schocher
2011-09-30 6:57 ` Christian Riesch
2011-09-30 7:11 ` Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 7/8] arm, davinci, da8xx: add cpuinfo Heiko Schocher
2011-09-15 5:59 ` [U-Boot] [PATCH 8/8] arm, davinci: add support for am1808 based enbw_cmc board Heiko Schocher
2011-09-15 7:39 ` Igor Grinberg
2011-09-15 7:56 ` Heiko Schocher
2011-09-19 5:50 ` [U-Boot] [PATCH v2 " Heiko Schocher
2011-09-23 20:47 ` Paulraj, Sandeep
2011-09-26 5:43 ` Heiko Schocher
2011-09-26 6:03 ` Paulraj, Sandeep
2011-09-26 6:08 ` Heiko Schocher
2011-09-27 7:05 ` Albert ARIBAUD
2011-09-30 7:55 ` Christian Riesch
2011-09-30 8:46 ` Heiko Schocher [this message]
2011-09-30 9:02 ` Christian Riesch
2011-09-30 9:32 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8581FF.3020507@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox