[U-Boot] [PATCH v7 3/3] MIPS: JZ4740: Add qi_lb60 board support

Wolfgang Denk
2011-10-06T21:11:40Z

Dear Shinya Kuribayashi,

In message <4E886DA5.1010806@pobox.com> you wrote:
> From: Xiangfu Liu <xiangfu@openmobilefree.net>
> Date: Fri, 19 Aug 2011 14:35:29 +0800
>
> Add support for the qi_lb60 (a.k.a QI Ben NanoNote) clamshell device
> from Qi hardware:
>
> http://en.qi-hardware.com/wiki/Ben_NanoNote
> http://en.qi-hardware.com/wiki/Main_Page
> http://en.wikipedia.org/wiki/Qi_hardware
>
> This Jz4740-based clamshell device does not use NOR flash to boot.
> The initial bring-up assumes that U-Boot is directly loaded into SDRAM
> using USB boot tool, and starts from 0x80100000.
>
> About USB boot tool
> -------------------
>
> Jz4740 is one of the XBurst processors with USB boot functionality
> supported. The CPU can boot from a small ROM in the LSI, initialize
> CPU and USB module, then wait for USB commands from the USB host.
> We can send 8 KB binary data to the CPU cache using USB boot tool.
>
> USB boot tool is available to the public at Ingenic website. Also
> there is an alternative Debian package named xburst-tools.
>
> Signed-off-by: Xiangfu Liu <xiangfu@openmobilefree.net>
> Acked-by: Daniel <zpxu@ingenic.cn>
> Signed-off-by: Shinya Kuribayashi <skuribay@pobox.com>
> ---
>
> Changes since v6:
>
> * <nanonote.h> config files is folded into <qi_lb60.h>
>
> * Following configs are deleted:
> CONFIG_SYS_64BIT_VSPRINTF
> CONFIG_NANDBOOT_CFG
> CONFIG_QI_LB60
>
> MAINTAINERS | 4 +
> MAKEALL | 4 +-
> board/qi/qi_lb60/Makefile | 45 +++++++++
> board/qi/qi_lb60/config.mk | 31 +++++++
> board/qi/qi_lb60/qi_lb60.c | 104 +++++++++++++++++++++
> board/qi/qi_lb60/u-boot.lds | 61 +++++++++++++
> boards.cfg | 1 +
> include/configs/qi_lb60.h | 210 +++++++++++++++++++++++++++++++++++++++++++
> 8 files changed, 459 insertions(+), 1 deletions(-)
> create mode 100644 board/qi/qi_lb60/Makefile
> create mode 100644 board/qi/qi_lb60/config.mk
> create mode 100644 board/qi/qi_lb60/qi_lb60.c
> create mode 100644 board/qi/qi_lb60/u-boot.lds
> create mode 100644 include/configs/qi_lb60.h

Checkpatch says:

total: 1 errors, 12 warnings, 478 lines checked

Please clean up and resubmit. Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You humans have that emotional need to express gratitude. "You're
welcome," I believe, is the correct response.
-- Spock, "Bread and Circuses", stardate 4041.2