public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nick Thompson <nick.thompson@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] da830: add support to read mac addr from EEPROM
Date: Mon, 03 Oct 2011 13:01:05 +0100	[thread overview]
Message-ID: <4E89A401.30503@ge.com> (raw)
In-Reply-To: <1317382799-11205-1-git-send-email-nagabhushana.netagunte@ti.com>

On 30/09/11 12:39, nagabhushana.netagunte at ti.com wrote:
> From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
>
> da830 boards have mac address stored in I2C EEPROM. This patch
> adds support to restore mac address from EEPROM if environment variable
> 'ethaddr' is not set.
>
> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> ---
>  board/davinci/da8xxevm/da830evm.c |   20 ++++++++++++++++++++
>  include/configs/da830evm.h        |    1 +
>  2 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/board/davinci/da8xxevm/da830evm.c b/board/davinci/da8xxevm/da830evm.c
> index 0650653..69ed293 100644
> --- a/board/davinci/da8xxevm/da830evm.c
> +++ b/board/davinci/da8xxevm/da830evm.c
> @@ -188,6 +188,26 @@ int board_init(void)
>  
>  #define PHY_SW_I2C_ADDR	0x5f /* Address of PHY on i2c bus */
>  
> +int misc_init_r(void)
> +{
> +	uint8_t eeprom_enetaddr[6];
> +	uint8_t val[2];
> +
> +	if (!eth_getenv_enetaddr("ethaddr", eeprom_enetaddr)) {
> +		/* Read Ethernet MAC address from EEPROM if available. */
> +		if (dvevm_read_mac_address(eeprom_enetaddr))
> +			/* Set Ethernet MAC address from EEPROM */
> +			davinci_sync_env_enetaddr(eeprom_enetaddr);
> +	}
> +
> +	val[0] = 0x01;
> +	val[1] = 0x23;
> +
> +	if (i2c_write(PHY_SW_I2C_ADDR, 0, 0, val, 2))
> +		printf("Ethernet switch start failed!\n");
> +
> +}
> +

There is already code to do this, in the same file, in board_eth_init(). Why the new code?

Nick.

>  /*
>   * Initializes on-board ethernet controllers.
>   */
> diff --git a/include/configs/da830evm.h b/include/configs/da830evm.h
> index 66fdea2..a451513 100644
> --- a/include/configs/da830evm.h
> +++ b/include/configs/da830evm.h
> @@ -160,6 +160,7 @@
>  /*
>   * U-Boot general configuration
>   */
> +#define CONFIG_MISC_INIT_R
>  #undef CONFIG_USE_IRQ			/* No IRQ/FIQ in U-Boot */
>  #undef CONFIG_MISC_INIT_R
>  #undef CONFIG_BOOTDELAY

  parent reply	other threads:[~2011-10-03 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 11:39 [U-Boot] [PATCH] da830: add support to read mac addr from EEPROM nagabhushana.netagunte at ti.com
2011-09-30 15:49 ` Mike Frysinger
2011-10-03 12:01 ` Nick Thompson [this message]
2011-10-04 13:50   ` Netagunte, Nagabhushana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E89A401.30503@ge.com \
    --to=nick.thompson@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox