public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] nand: Add common functions to nand.h
Date: Mon, 3 Oct 2011 18:54:31 -0500	[thread overview]
Message-ID: <4E8A4B37.4040804@freescale.com> (raw)
In-Reply-To: <1317282243-14848-3-git-send-email-simonschwarzcor@gmail.com>

On 09/29/2011 02:44 AM, Simon Schwarz wrote:
> Functions often used in SPL are now part of nand.h.
> 
> Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
> ---
>  include/nand.h |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/include/nand.h b/include/nand.h
> index b4140794..980408a 100644
> --- a/include/nand.h
> +++ b/include/nand.h
> @@ -135,9 +135,6 @@ int nand_get_lock_status(nand_info_t *meminfo, loff_t offset);
>  int nand_spl_load_image(uint32_t offs, unsigned int size, void *dst);
>  void nand_deselect(void);
>  
> -void nand_read_buf16(struct mtd_info *mtd, uint8_t *buf, int len);
> -void nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len);
> -
>  #ifdef CONFIG_SYS_NAND_SELECT_DEVICE
>  void board_nand_select_device(struct nand_chip *nand, int chip);
>  #endif
> @@ -154,3 +151,10 @@ __attribute__((noreturn)) void nand_boot(void);
>  #define ENV_OFFSET_SIZE 8
>  int get_nand_env_oob(nand_info_t *nand, unsigned long *result);
>  #endif
> +
> +/* Standard NAND functions from nand_base.c */
> +void nand_write_buf(struct mtd_info *mtd, const uint8_t *buf, int len);
> +void nand_write_buf16(struct mtd_info *mtd, const uint8_t *buf, int len);
> +void nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len);
> +void nand_read_buf16(struct mtd_info *mtd, uint8_t *buf, int len);
> +uint8_t nand_read_byte(struct mtd_info *mtd);

Sorry for not noticing this before, but these should go in
include/linux/mtd/nand.h since that corresponds to
drivers/mtd/nand/nand_base.c.  include/nand.h is for U-Boot-specific things.

As it stands now, drivers/mtd/nand/nand_base.c does not include
include/nand.h, so we won't get warned if the function signatures diverge.

-Scott

  reply	other threads:[~2011-10-03 23:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29  7:44 [U-Boot] [PATCH 0/3] fix: regression in SMDK6400 Simon Schwarz
2011-09-29  7:44 ` [U-Boot] [PATCH 1/3] nand: Remove static modifier from common functions Simon Schwarz
2011-09-29  7:44 ` [U-Boot] [PATCH 2/3] nand: Add common functions to nand.h Simon Schwarz
2011-10-03 23:54   ` Scott Wood [this message]
     [not found]     ` <CAA5zgp_P9LtYraPUPQSM1PPDg_eGHAJ0F-qXHwiF-B+69NS1oQ@mail.gmail.com>
2011-10-14 18:09       ` Simon Schwarz
2011-09-29  7:44 ` [U-Boot] [PATCH 3/3] Fix regression in SMDK6400 Simon Schwarz
2011-09-29 16:07 ` [U-Boot] [PATCH 0/3] fix: " Scott Wood
2011-10-16 10:50 ` Simon Schwarz
2011-10-16 10:50   ` [U-Boot] [PATCH 1/3] nand: Remove static modifier from common functions Simon Schwarz
2011-10-28 20:45     ` Scott Wood
2011-10-16 10:50   ` [U-Boot] [PATCH 2/3] nand: Add common functions to linux/mtd/nand.h Simon Schwarz
2011-10-28 20:46     ` Scott Wood
2011-10-16 10:50   ` [U-Boot] [PATCH 3/3] Fix regression in SMDK6400 Simon Schwarz
2011-10-31 16:34   ` [U-Boot] [PATCH V3 0/2] fix: " Simon Schwarz
2011-10-31 16:34     ` [U-Boot] [PATCH V3 1/2] nand: Add common functions to linux/mtd/nand.h Simon Schwarz
2011-10-31 17:52       ` Scott Wood
2011-11-25 19:05         ` Albert ARIBAUD
2011-11-25 19:12           ` Albert ARIBAUD
2011-10-31 16:34     ` [U-Boot] [PATCH V3 2/2] Fix regression in SMDK6400 Simon Schwarz
2011-11-25 19:40     ` [U-Boot] [PATCH V3 0/2] fix: " Albert ARIBAUD
2011-11-29  8:32       ` Simon Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8A4B37.4040804@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox