[U-Boot] [PATCH V2 3/3] mx31: Add board support for HALE TT-01

stefano babic
2011-10-15T05:40:19Z

Am 14/10/2011 23:14, schrieb Wolfgang Denk:
> Dear Stefano Babic,
>
> In message <4E981741.6050809@denx.de> you wrote:
>>
>>> + while (wait--) ;
>
> Checkpatch is supposed to complain about this; the semicolon goes on
> the next line.

You're right.

>> I had the same problem - a udelay() before relocation.
>
> This should be no problem. udelay() is supposed to work fine very
> early - ling before relocation.

Maybe I should be more clearer - we need a way to wait some time when
even PLL or clock module (for i.MX) are not yet programmed.

>
>> However, there is a sdelay() in armv7 (syslib.c), and I sent a patch to
>> move this stuff into arm/lib to make this and the other functions
>> available to all ARM SOCs
>
> What the hell is sdelay()?
>
> Please let us not introduce arbitrary new functions without need.

This is *not* a new function. I see it was introduced for OMAP3 since a
lot of time ago. I do not want to introduce another function, I will
reuse what is already available for other SOCs.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================