[U-Boot] [PATCH 2/2] TT-01: add basic board support for HALE TT-01

Fabio Estevam
2011-09-22T13:36:39Z

On Thu, Sep 22, 2011 at 9:12 AM, Helmut Raiger <helmut.raiger@hale.at> wrote:
> This adds basic board support for TT-01 based on
> the bluetechnix i.MX31 SOM. Currently only NOR-Flash
> boot is supported.
>
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> ---
> ?Makefile ? ? ? ? ? ? ? ? ?| ? ?4 +
> ?board/hale/tt01/Makefile ?| ? 53 +++++++++
> ?board/hale/tt01/config.mk | ? ?1 +
> ?board/hale/tt01/tt01.c ? ?| ? 98 ++++++++++++++++
> ?include/configs/tt01.h ? ?| ?283 +++++++++++++++++++++++++++++++++++++++++++++
> ?5 files changed, 439 insertions(+), 0 deletions(-)
> ?create mode 100644 board/hale/tt01/Makefile
> ?create mode 100644 board/hale/tt01/config.mk
> ?create mode 100644 board/hale/tt01/tt01.c
> ?create mode 100644 include/configs/tt01.h

You missed to add an entry to the MAINTAINERS file.

...

> diff --git a/board/hale/tt01/config.mk b/board/hale/tt01/config.mk
> new file mode 100644
> index 0000000..a7887ba
> --- /dev/null
> +++ b/board/hale/tt01/config.mk
> @@ -0,0 +1 @@
> +CONFIG_SYS_TEXT_BASE = 0xa0000000

Do you really need to create one file to store a single line?

You can place CONFIG_SYS_TEXT_BASE in the tt01.h

> diff --git a/board/hale/tt01/tt01.c b/board/hale/tt01/tt01.c
> new file mode 100644
> index 0000000..3bae2b4
> --- /dev/null
...

> + ? ? ? /* start CSPI3 clock (3 = always on except if PLL off) */
> + ? ? ? writel(readl(CCM_CGR0) | (3 << 16), CCM_CGR0);

You can use setbits_le32 here.

Regards,

Fabio Estevam