From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 05 Oct 2011 15:49:40 +0200 Subject: [U-Boot] [PATCH 13/13] Davinci: ea20: use gpio framework to access gpios In-Reply-To: <20111005131421.GF8500@lwithers.me.uk> References: <1317807819-17056-1-git-send-email-sbabic@denx.de> <1317820104-22208-1-git-send-email-sbabic@denx.de> <20111005131421.GF8500@lwithers.me.uk> Message-ID: <4E8C6074.6090001@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/05/2011 03:14 PM, Laurence Withers wrote: > On Wed, Oct 05, 2011 at 03:08:24PM +0200, Stefano Babic wrote: >> Drop direct access to SOC's registers and use >> the function of the GPIO driver for da8xx. > > Dear Stefano, > > The da8xx GPIO driver also configures the pinmux for you. > > Bye for now, That's true, but this was wanted. IMHO is the usage of the functions gpio_request() and gpio_free() optional. I decided to program myself the pinmux also for the gpio together with the setup of the pinmux for the other controllers of the SOC, everything in the ea20.c file. this allows to see all code managing the pinmux on this board in one place. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================