From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 06 Oct 2011 07:41:19 +0200 Subject: [U-Boot] [PATCH v2 05/10] spl, nand: add 4bit HW ecc oob first nand_read_page function In-Reply-To: <4E8CD00C.9070900@freescale.com> References: <1317824907-8693-1-git-send-email-hs@denx.de> <4E8CD00C.9070900@freescale.com> Message-ID: <4E8D3F7F.6060707@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Scott, Scott Wood wrote: > On 10/05/2011 09:28 AM, Heiko Schocher wrote: >> similiar to commit dc7cd8e59ba077f3b4c1a4557c9cd86a31b9ab1f, only >> adapted for the new spl framework. >> >> Signed-off-by: Heiko Schocher >> Cc: Scott Wood >> Cc: Albert ARIBAUD >> Cc: Sandeep Paulraj >> --- >> drivers/mtd/nand/nand_spl_simple.c | 43 ++++++++++++++++++++++++++++++++++++ >> 1 files changed, 43 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mtd/nand/nand_spl_simple.c b/drivers/mtd/nand/nand_spl_simple.c >> index 71491d4..7ab332f 100644 >> --- a/drivers/mtd/nand/nand_spl_simple.c >> +++ b/drivers/mtd/nand/nand_spl_simple.c [...] >> @@ -186,6 +227,7 @@ static int nand_read_page(int block, int page, void *dst) >> >> return 0; >> } >> +#endif >> >> int nand_spl_load_image(uint32_t offs, unsigned int size, void *dst) >> { > > ACK this part great! >> @@ -231,6 +273,7 @@ void nand_init(void) >> nand_chip.IO_ADDR_R = nand_chip.IO_ADDR_W = >> (void __iomem *)CONFIG_SYS_NAND_BASE; >> nand_chip.options = 0; >> + nand_chip.dev_ready = NULL; >> board_nand_init(&nand_chip); >> >> if (nand_chip.select_chip) > > This looks unrelated, and if it makes a difference suggests that the BSS > isn't being cleared. BSS is cleared at this point, so you are right, above two lines are not necessary, remove them. Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany