From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Thu, 6 Oct 2011 16:07:13 -0500
Subject: [U-Boot] [PATCH 3/3] powerpc/85xx: wait for alignment before
 resetting SERDES RX lanes (SERDES9)
In-Reply-To: <20111006210355.C10BC140874A@gemini.denx.de>
References: <1317841251-27295-1-git-send-email-timur@freescale.com>
	<1317841251-27295-3-git-send-email-timur@freescale.com>
	<20111006210355.C10BC140874A@gemini.denx.de>
Message-ID: <4E8E1881.5030902@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:

> WARNING: externs should be avoided in .c files
> #114: FILE: board/freescale/corenet_ds/eth_p4080.c:100:
> +       extern struct phy_driver tn2020_driver;

This is intentional.  There's no header file for the teranetics driver, and
referencing the structure allows me to avoid a hard-coded number.

Are you suggesting that I create a header file just to contain this line:

	extern struct phy_driver tn2020_driver;

because that seems silly.

-- 
Timur Tabi
Linux kernel developer at Freescale