From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] nand: Merge changes from Linux nand driver
Date: Thu, 6 Oct 2011 16:25:00 -0500 [thread overview]
Message-ID: <4E8E1CAC.6000405@freescale.com> (raw)
In-Reply-To: <20111006210607.900BE140874A@gemini.denx.de>
On 10/06/2011 04:06 PM, Wolfgang Denk wrote:
> Dear "Hitz, Christian",
>
> In message <CD1B567EF015FE41B29FF476B8600DDD26BBF25B89@vsrv-mail01.newtechgroup.local> you wrote:
>> This patch synchronizes the nand driver with the Linux 3.0 state.
>>
>> Signed-off-by: Christian Hitz <christian.hitz@aizo.com>
>> ---
>> drivers/mtd/nand/nand_base.c | 578 +++++++++++++++++++++++++++++-------------
>> drivers/mtd/nand/nand_bbt.c | 423 ++++++++++++++++++++++++-------
>> drivers/mtd/nand/nand_ecc.c | 560 +++++++++++++++++++++++++++++++---------
>> include/linux/mtd/bbm.h | 29 ++-
>> include/linux/mtd/nand.h | 378 ++++++++++++++++------------
>> include/linux/string.h | 46 +++-
>> lib/string.c | 461 ++++++++++++++++++++--------------
>> 7 files changed, 1709 insertions(+), 766 deletions(-)
What do the string changes have to do with synchronizing the NAND driver?
How much does this update affect image size? This may be a good time to
start ifdeffing portions of the NAND code based on what's actually
needed by the target.
> Checkpatch says:
>
> total: 662 errors, 1167 warnings, 3783 lines checked
>
> Please clean up and resubmit. Thanks.
It looks like the entire patch is whitespace-mangled.
That said, if there are any remaining checkpatch complaints due to the
way the code already exists in Linux, I don't think we should make a
local change to U-Boot just to keep checkpatch happy.
-Scott
next prev parent reply other threads:[~2011-10-06 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 8:45 [U-Boot] [PATCH 2/2] nand: Merge changes from Linux nand driver Hitz, Christian
2011-10-06 21:06 ` Wolfgang Denk
2011-10-06 21:25 ` Scott Wood [this message]
2011-10-06 22:23 ` Wolfgang Denk
2011-10-07 15:04 ` Christian Hitz
2011-10-07 15:46 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8E1CAC.6000405@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox