From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Thu, 6 Oct 2011 16:25:00 -0500 Subject: [U-Boot] [PATCH 2/2] nand: Merge changes from Linux nand driver In-Reply-To: <20111006210607.900BE140874A@gemini.denx.de> References: <20111006210607.900BE140874A@gemini.denx.de> Message-ID: <4E8E1CAC.6000405@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/06/2011 04:06 PM, Wolfgang Denk wrote: > Dear "Hitz, Christian", > > In message you wrote: >> This patch synchronizes the nand driver with the Linux 3.0 state. >> >> Signed-off-by: Christian Hitz >> --- >> drivers/mtd/nand/nand_base.c | 578 +++++++++++++++++++++++++++++------------- >> drivers/mtd/nand/nand_bbt.c | 423 ++++++++++++++++++++++++------- >> drivers/mtd/nand/nand_ecc.c | 560 +++++++++++++++++++++++++++++++--------- >> include/linux/mtd/bbm.h | 29 ++- >> include/linux/mtd/nand.h | 378 ++++++++++++++++------------ >> include/linux/string.h | 46 +++- >> lib/string.c | 461 ++++++++++++++++++++-------------- >> 7 files changed, 1709 insertions(+), 766 deletions(-) What do the string changes have to do with synchronizing the NAND driver? How much does this update affect image size? This may be a good time to start ifdeffing portions of the NAND code based on what's actually needed by the target. > Checkpatch says: > > total: 662 errors, 1167 warnings, 3783 lines checked > > Please clean up and resubmit. Thanks. It looks like the entire patch is whitespace-mangled. That said, if there are any remaining checkpatch complaints due to the way the code already exists in Linux, I don't think we should make a local change to U-Boot just to keep checkpatch happy. -Scott