From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Fri, 07 Oct 2011 00:11:39 +0200 Subject: [U-Boot] [PATCH 5/8] ARM: moved general function to arm/lib In-Reply-To: <20111006213019.8AF051408751@gemini.denx.de> References: <1316166383-11314-1-git-send-email-sbabic@denx.de> <1316166383-11314-5-git-send-email-sbabic@denx.de> <20111006213019.8AF051408751@gemini.denx.de> Message-ID: <4E8E279B.8000405@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 06/10/2011 23:30, schrieb Wolfgang Denk: > Dear Stefano Babic, > > In message <1316166383-11314-5-git-send-email-sbabic@denx.de> you wrote: >> Functions inside armv7/syslib can be used by other ARM >> architectures, too. The file is added as part of >> ARM library. >> >> Signed-off-by: Stefano Babic >> CC: Albert ARIBAUD >> --- >> arch/arm/cpu/armv7/Makefile | 2 - >> arch/arm/cpu/armv7/syslib.c | 69 ------------------------------------------- >> arch/arm/lib/Makefile | 2 + >> arch/arm/lib/syslib.c | 69 +++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 71 insertions(+), 71 deletions(-) >> delete mode 100644 arch/arm/cpu/armv7/syslib.c >> create mode 100644 arch/arm/lib/syslib.c > > Checkpatch says: > > total: 2 errors, 0 warnings, 85 lines checked > > Please clean up and resubmit. Thanks. mmhhh..I do not know if this is correct. The patch is really only a "git mv", an the original files are only moved. If I run checkpatch, I see: ERROR: spaces required around that ':' (ctx:VxV) #164: FILE: arch/arm/lib/syslib.c:37: + "bne 1b":"=r" (loops):"0"(loops)); ^ ERROR: spaces required around that ':' (ctx:VxV) #164: FILE: arch/arm/lib/syslib.c:37: + "bne 1b":"=r" (loops):"0"(loops)); ^ total: 2 errors, 0 warnings, 85 lines checked This is an assembly inline - are we sure we apply the same rules for C and assembly ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================