From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx
Date: Fri, 07 Oct 2011 00:22:58 +0200 [thread overview]
Message-ID: <4E8E2A42.6040707@denx.de> (raw)
In-Reply-To: <20111007001427.5d578407@wker>
Am 07/10/2011 00:14, schrieb Anatolij Gustschin:
> Hi Stefano,
>
Hi Anatolij,
>> +++ b/arch/arm/include/asm/arch-davinci/da8xx-fb.h
>> @@ -0,0 +1,122 @@
>> +/*
>> + * Header file for TI DA8XX LCD controller platform data.
>> + *
>> + * Copyright (C) 2008-2009 MontaVista Software Inc.
>> + * Copyright (C) 2008-2009 Texas Instruments Inc
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2. This program is licensed "as is" without any warranty of any
>> + * kind, whether express or implied.
>> + */
>
> Hmm, the whole driver is under GPL v2 or any later version, but this
> header under GPL v2 only? Actually this doesn't make sense. Newly added
> code should use GPLv3-compatible licensing, e.g. GPL v2 or any later version.
Right - I will correct the whole header.
>
> ...
>> +#if 0
>> +/* ioctls */
>> +#define FBIOGET_CONTRAST _IOR('F', 1, int)
>> +#define FBIOPUT_CONTRAST _IOW('F', 2, int)
>> +#define FBIGET_BRIGHTNESS _IOR('F', 3, int)
>> +#define FBIPUT_BRIGHTNESS _IOW('F', 3, int)
>> +#define FBIGET_COLOR _IOR('F', 5, int)
>> +#define FBIPUT_COLOR _IOW('F', 6, int)
>> +#define FBIPUT_HSYNC _IOW('F', 9, int)
>> +#define FBIPUT_VSYNC _IOW('F', 10, int)
>> +#endif
>
> Please do not add dead code.
Thanks, I forget to drop it - fixed in V2.
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-10-06 22:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 9:43 [U-Boot] [PATCH 01/12] Davinci: ea20: set console on UART0 Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 02/12] Davinci: ea20: set GPIOs to hold MII-Phy in reset and set UART0-Switch for console Stefano Babic
2011-10-05 12:06 ` Laurence Withers
2011-10-05 13:00 ` Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 03/12] Davinci: ea20: Add NAND support Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 04/12] Davinci: ea20: Add early init to get early output from console Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 05/12] Davinci: ea20: Add default U-Boot environment Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 06/12] Davinci: ea20: add gpio for keeping power on in board_late_init Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 07/12] Davinci: ea20: add gpios for LCD backlight control Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 08/12] ARM: Davinci: added missing registers to hardware.h Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx Stefano Babic
2011-10-06 22:14 ` Anatolij Gustschin
2011-10-06 22:22 ` stefano babic [this message]
2011-10-06 22:32 ` Wolfgang Denk
2011-10-06 22:44 ` stefano babic
2011-10-07 4:42 ` Wolfgang Denk
2011-10-05 9:43 ` [U-Boot] [PATCH 10/12] Davinci: ea20: added video support Stefano Babic
2011-10-06 21:12 ` Anatolij Gustschin
2011-10-05 9:43 ` [U-Boot] [PATCH 11/12] Davinci: ea20: added I2C support Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 12/12] Davinci: ea20: added PREBOOT to configuration Stefano Babic
2011-10-05 13:08 ` [U-Boot] [PATCH 13/13] Davinci: ea20: use gpio framework to access gpios Stefano Babic
2011-10-05 13:14 ` Laurence Withers
2011-10-05 13:49 ` Stefano Babic
2011-10-08 9:27 ` [U-Boot] [PATCH V2 09/12] VIDEO: davinci: add framebuffer to da8xx Stefano Babic
2011-10-11 16:10 ` Anatolij Gustschin
2011-10-12 8:42 ` Stefano Babic
2011-10-12 9:06 ` Anatolij Gustschin
2011-10-12 9:35 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8E2A42.6040707@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox