From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Fri, 07 Oct 2011 00:22:58 +0200 Subject: [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx In-Reply-To: <20111007001427.5d578407@wker> References: <1317807819-17056-1-git-send-email-sbabic@denx.de> <1317807819-17056-9-git-send-email-sbabic@denx.de> <20111007001427.5d578407@wker> Message-ID: <4E8E2A42.6040707@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 07/10/2011 00:14, schrieb Anatolij Gustschin: > Hi Stefano, > Hi Anatolij, >> +++ b/arch/arm/include/asm/arch-davinci/da8xx-fb.h >> @@ -0,0 +1,122 @@ >> +/* >> + * Header file for TI DA8XX LCD controller platform data. >> + * >> + * Copyright (C) 2008-2009 MontaVista Software Inc. >> + * Copyright (C) 2008-2009 Texas Instruments Inc >> + * >> + * This file is licensed under the terms of the GNU General Public License >> + * version 2. This program is licensed "as is" without any warranty of any >> + * kind, whether express or implied. >> + */ > > Hmm, the whole driver is under GPL v2 or any later version, but this > header under GPL v2 only? Actually this doesn't make sense. Newly added > code should use GPLv3-compatible licensing, e.g. GPL v2 or any later version. Right - I will correct the whole header. > > ... >> +#if 0 >> +/* ioctls */ >> +#define FBIOGET_CONTRAST _IOR('F', 1, int) >> +#define FBIOPUT_CONTRAST _IOW('F', 2, int) >> +#define FBIGET_BRIGHTNESS _IOR('F', 3, int) >> +#define FBIPUT_BRIGHTNESS _IOW('F', 3, int) >> +#define FBIGET_COLOR _IOR('F', 5, int) >> +#define FBIPUT_COLOR _IOW('F', 6, int) >> +#define FBIPUT_HSYNC _IOW('F', 9, int) >> +#define FBIPUT_VSYNC _IOW('F', 10, int) >> +#endif > > Please do not add dead code. Thanks, I forget to drop it - fixed in V2. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================