From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/8] POST: add post_log_res field for post results in global data
Date: Fri, 07 Oct 2011 08:48:44 +0200 [thread overview]
Message-ID: <4E8EA0CC.5020700@keymile.com> (raw)
In-Reply-To: <20111006214405.D4E261408751@gemini.denx.de>
Hello Wolfgang,
On 10/06/2011 11:44 PM, Wolfgang Denk wrote:
> Dear Valentin Longchamp,
>
> In message <1314975550-15766-4-git-send-email-valentin.longchamp@keymile.com> you wrote:
>> The current post_log_word in global data is currently split into 2x
>> 16 bits: half for the test start, half for the test success.
>> Since we alredy have more than 16 POST tests defined and more could
>> be defined, this may result in an overflow and the post_output_backlog
>> would not work for the tests defined further of these 16 positions.
>>
>> An additional field is added to global data so that we can now support up
>> to 32 (depending of architecture) tests. The post_log_word is only used
>> to record the start of the test and the new field post_log_res for the
>> test success (or failure). The post_output_backlog is for this change
>> also adapted.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> Acked-by: Mike Frysinger <vapier@gentoo.org>
>> ---
>> arch/arm/include/asm/global_data.h | 1 +
>> arch/blackfin/include/asm/global_data.h | 1 +
>> arch/nios2/include/asm/global_data.h | 1 +
>> arch/powerpc/include/asm/global_data.h | 1 +
>> arch/sparc/include/asm/global_data.h | 1 +
>> post/post.c | 9 +++++----
>> 6 files changed, 10 insertions(+), 4 deletions(-)
>
> Checkpatch says:
>
> total: 0 errors, 1 warnings, 67 lines checked
>
> Please clean up and resubmit. Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
I have a question here:
There was a v4 version of these patches for which messages were sent yesterday
that they were applied. And now I receive these checkpatch warnings/errors
asking for resubmitting but for the v3 patches.
Could you please tell me what the exact status is ?
Then what exact checkpatch.pl version are you (or your script) using ? Because I
don't get the same output as you.
Best Regards
--
Valentin Longchamp
Embedded Software Engineer
Hardware and Chip Integration
______________________________________
KEYMILE AG
Schwarzenburgstr. 73
CH-3097 Liebefeld
Phone +41 31 377 1318
Fax +41 31 377 1212
valentin.longchamp at keymile.com
www.keymile.com
______________________________________
KEYMILE: A Specialist as a Partner
next prev parent reply other threads:[~2011-10-07 6:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 14:59 [U-Boot] [PATCH v3 0/8] POST: support for km_arm and mem_regions test definition Valentin Longchamp
2011-09-02 14:59 ` [U-Boot] [PATCH v3 1/8] POST/arm: adaptations needed for POST on ARM to work Valentin Longchamp
2011-09-02 15:49 ` Mike Frysinger
2011-09-02 14:59 ` [U-Boot] [PATCH v3 2/8] POST: allow redefinition of post_word_load/store Valentin Longchamp
2011-09-02 14:59 ` [U-Boot] [PATCH v3 3/8] POST: add post_log_res field for post results in global data Valentin Longchamp
2011-10-06 21:44 ` Wolfgang Denk
2011-10-07 6:48 ` Valentin Longchamp [this message]
2011-09-02 14:59 ` [U-Boot] [PATCH v3 4/8] POST: make env test flags fetching optional Valentin Longchamp
2011-09-02 14:59 ` [U-Boot] [PATCH v3 5/8] POST: drivers/memory.c coding style cleanup Valentin Longchamp
2011-10-06 21:43 ` Wolfgang Denk
2011-09-02 14:59 ` [U-Boot] [PATCH v3 6/8] POST: add new memory regions test Valentin Longchamp
2011-09-02 15:49 ` Mike Frysinger
2011-10-06 21:42 ` Wolfgang Denk
2011-09-02 14:59 ` [U-Boot] [PATCH v3 7/8] km_arm: change CONFIG_SYS_TEXT_BASE to end of RAM Valentin Longchamp
2011-09-05 6:35 ` Heiko Schocher
2011-09-12 12:21 ` [U-Boot] [PATCH v3 7/8] km_arm: change CONFIG_SYS_TEXT_BASE to endof RAM Valentin Longchamp
2011-09-02 14:59 ` [U-Boot] [PATCH v3 8/8] km_arm: enable POST for these boards Valentin Longchamp
2011-10-21 22:15 ` Wolfgang Denk
2011-10-24 7:12 ` Holger Brunck
2011-10-24 19:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EA0CC.5020700@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox