From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Longchamp Date: Fri, 07 Oct 2011 08:48:44 +0200 Subject: [U-Boot] [PATCH v3 3/8] POST: add post_log_res field for post results in global data In-Reply-To: <20111006214405.D4E261408751@gemini.denx.de> References: <1314975550-15766-1-git-send-email-valentin.longchamp@keymile.com> <1314975550-15766-4-git-send-email-valentin.longchamp@keymile.com> <20111006214405.D4E261408751@gemini.denx.de> Message-ID: <4E8EA0CC.5020700@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, On 10/06/2011 11:44 PM, Wolfgang Denk wrote: > Dear Valentin Longchamp, > > In message <1314975550-15766-4-git-send-email-valentin.longchamp@keymile.com> you wrote: >> The current post_log_word in global data is currently split into 2x >> 16 bits: half for the test start, half for the test success. >> Since we alredy have more than 16 POST tests defined and more could >> be defined, this may result in an overflow and the post_output_backlog >> would not work for the tests defined further of these 16 positions. >> >> An additional field is added to global data so that we can now support up >> to 32 (depending of architecture) tests. The post_log_word is only used >> to record the start of the test and the new field post_log_res for the >> test success (or failure). The post_output_backlog is for this change >> also adapted. >> >> Signed-off-by: Valentin Longchamp >> Signed-off-by: Holger Brunck >> Acked-by: Mike Frysinger >> --- >> arch/arm/include/asm/global_data.h | 1 + >> arch/blackfin/include/asm/global_data.h | 1 + >> arch/nios2/include/asm/global_data.h | 1 + >> arch/powerpc/include/asm/global_data.h | 1 + >> arch/sparc/include/asm/global_data.h | 1 + >> post/post.c | 9 +++++---- >> 6 files changed, 10 insertions(+), 4 deletions(-) > > Checkpatch says: > > total: 0 errors, 1 warnings, 67 lines checked > > Please clean up and resubmit. Thanks. > > Best regards, > > Wolfgang Denk > I have a question here: There was a v4 version of these patches for which messages were sent yesterday that they were applied. And now I receive these checkpatch warnings/errors asking for resubmitting but for the v3 patches. Could you please tell me what the exact status is ? Then what exact checkpatch.pl version are you (or your script) using ? Because I don't get the same output as you. Best Regards -- Valentin Longchamp Embedded Software Engineer Hardware and Chip Integration ______________________________________ KEYMILE AG Schwarzenburgstr. 73 CH-3097 Liebefeld Phone +41 31 377 1318 Fax +41 31 377 1212 valentin.longchamp at keymile.com www.keymile.com ______________________________________ KEYMILE: A Specialist as a Partner