public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] nand: Merge changes from Linux nand driver
Date: Fri, 7 Oct 2011 10:46:33 -0500	[thread overview]
Message-ID: <4E8F1ED9.5040701@freescale.com> (raw)
In-Reply-To: <4E8F14EA.9040902@aizo.com>

On 10/07/2011 10:04 AM, Christian Hitz wrote:
> Am 06.10.2011 23:25, schrieb Scott Wood:
>> What do the string changes have to do with synchronizing the NAND driver?
> 
> Strings read from ONFI are now sanitized. For that strim() is used which
> was not yet available in U-Boots string library. Of course I went
> overboard with syncing the whole string library. I'll submit a new
> version that only adds strim().

Please make it a separate patch.

>> How much does this update affect image size?  This may be a good time to
>> start ifdeffing portions of the NAND code based on what's actually
>> needed by the target.
> 
> before: u-boot.bin: 298112 bytes
> after: u-boot.bin: 301928 bytes
> (based on our at91sam9g20ek based design, ONFI enabled)
> 
> One option would be to ifdef the 1-bit software ECC. This would free
> aroud 2k (down to: 299744 bytes).

There are a bunch of things that could be ifdeffed, which gc-sections
doesn't help with because they are referenced with things like:

	if (!pointer)
		pointer = some_func;


Think large page versus small page, functions that the hw-specific
driver overrides, all the different types of ECC (ifdeffing out 1-bit
but not 4 or 8 won't keep U-Boot from growing on boards that use 1-bit),
ONFI, the read_page/write_page variants, etc.

-Scott

      reply	other threads:[~2011-10-07 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  8:45 [U-Boot] [PATCH 2/2] nand: Merge changes from Linux nand driver Hitz, Christian
2011-10-06 21:06 ` Wolfgang Denk
2011-10-06 21:25   ` Scott Wood
2011-10-06 22:23     ` Wolfgang Denk
2011-10-07 15:04     ` Christian Hitz
2011-10-07 15:46       ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8F1ED9.5040701@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox