From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sat, 08 Oct 2011 16:37:58 +0200 Subject: [U-Boot] [PATCH 04/11] misc: pmic: addI2C support to pmic_fsl driver In-Reply-To: <4E9056D5.4040800@mvista.com> References: <1318068428-3453-1-git-send-email-sbabic@denx.de> <1318068428-3453-5-git-send-email-sbabic@denx.de> <4E9056D5.4040800@mvista.com> Message-ID: <4E906046.6090708@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/08/2011 03:57 PM, Sergei Shtylyov wrote: > Hello. > > On 08-10-2011 14:07, Stefano Babic wrote: > >> Signed-off-by: Stefano Babic >> --- >> +#elif defined(CONFIG_PMIC_I2C) >> + p->interface = PMIC_SPI; >> + p->interface = PMIC_I2C; > > You assign one value and immediately assign the other. First > assignment shouldn't be here. Right - I drop it in V2, thanks. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================