From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Yanok <yanok@emcraft.com>
Date: Sun, 09 Oct 2011 14:41:47 +0400
Subject: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache
 enabled
In-Reply-To: <201110071334.20378.vapier@gentoo.org>
References: <1317857806-16549-1-git-send-email-yanok@emcraft.com>
	<1317857806-16549-5-git-send-email-yanok@emcraft.com>
	<201110071334.20378.vapier@gentoo.org>
Message-ID: <4E917A6B.1010200@emcraft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Mike,

On 07.10.2011 21:34, Mike Frysinger wrote:
>> +#ifdef DAVINCI_EMAC_DCACHE
>> +static inline void davinci_flush(void *addr, int size)
>> +{
>> +	flush_dcache_range((unsigned long)addr,
>> +			(unsigned long)addr + size);
>> +}
>> +
>> +static inline void davinci_invalidate(void *addr, int size)
>> +{
>> +	invalidate_dcache_range((unsigned long)addr,
>> +			(unsigned long)addr + size);
>> +}
>> +#else
>> +#define davinci_flush(addr, size)	do {} while (0)
>> +#define davinci_invalidate(addr, size)	do {} while (0)
>> +#endif
> 
> does it really make sense to have this be conditional ?

arm926ejs doesn't have {invalidate,flush}_dcache_range(), so we have to
add this not to break the driver on DaVinci boards (maybe we need to add
empty cache functions on arm926ejs instead?)

Regards, Ilya.