public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/13] I2c: add missing i2c_set_bus_num to mxc_i2c
Date: Mon, 10 Oct 2011 11:30:29 +0200	[thread overview]
Message-ID: <4E92BB35.1040607@denx.de> (raw)
In-Reply-To: <4E92B1DD.6040802@denx.de>

On 10/10/2011 10:50 AM, Heiko Schocher wrote:
> Hello Stefano,
> 
> Stefano Babic wrote:
>> The function i2c_set_bus_num() is used on most SOCs.
>> The driver does not support multiple I2C busses, and
>> an empty function is added to be compatible with general code
>> (example: PMIC driver).
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> Cc: Heiko Schocher <hs@denx.de>
>> ---
>>  drivers/i2c/mxc_i2c.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> Hmm... it would be better to add a weak function in
> u-boot/common/cmd_i2c.c ... as it is done for i2c_set_bus_speed()
> and i2c_get_bus_speed() functions.

Good idea, I missed it..changed in V2.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2011-10-10  9:30 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-08 16:35 [U-Boot] switch to generic PMIC driver for i.MX boards Stefano Babic
2011-10-08 16:35 ` [U-Boot] [PATCH 01/13] MX5: vision2: use new pmic driver Stefano Babic
2011-10-08 16:35 ` [U-Boot] [PATCH 02/13] RTC: Switch mc13783 to generic pmic code Stefano Babic
2011-10-08 16:35 ` [U-Boot] [PATCH 03/13] MX3: qong: use new pmic driver Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH V2 04/13] MX5: efikamx/efikasb: " Stefano Babic
2011-10-08 16:57   ` Marek Vasut
2011-10-08 16:36 ` [U-Boot] [PATCH 05/13] I2c: add missing i2c_set_bus_num to mxc_i2c Stefano Babic
2011-10-10  8:50   ` Heiko Schocher
2011-10-10  9:30     ` Stefano Babic [this message]
2011-10-08 16:36 ` [U-Boot] [PATCH V2 06/13] misc: pmic: addI2C support to pmic_fsl driver Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH 07/13] MX35: mx35pdk: use new pmic driver Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH V2 08/13] MX5: mx51evk: " Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH V2 09/13] MX5: mx53evk: " Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH 10/13] MX31: mx31_litekit: " Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH 11/13] MX31: mx31ads: " Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH 12/13] MX31: mx31pdk: " Stefano Babic
2011-10-08 16:36 ` [U-Boot] [PATCH 13/13] misc: pmic: drop old Freescale's " Stefano Babic
2011-10-19 13:23   ` Helmut Raiger
2011-10-19 15:39     ` Stefano Babic
2011-10-19 16:48       ` [U-Boot] [PATCH] misc: pmic: fix regression in pmic_fsl.c (SPI) Helmut Raiger
2011-10-19 17:15         ` Stefano Babic
2011-10-20  6:41           ` Helmut Raiger
2011-10-20  6:28         ` [U-Boot] [PATCH V2] " Helmut Raiger
2011-10-20  6:34         ` [U-Boot] [Resend PATCH " Helmut Raiger
2011-10-20  7:31           ` Stefano Babic
2011-10-24  7:48           ` Stefano Babic
2011-10-10  9:35 ` [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function Stefano Babic
2011-10-10 10:33   ` Heiko Schocher
2011-10-10 17:53   ` Tabi Timur-B04825
2011-10-10 18:26     ` Mike Frysinger
2011-10-10 18:29       ` Timur Tabi
2011-10-11  7:33       ` Stefano Babic
2011-10-11  5:37     ` Heiko Schocher
2011-10-11  5:48       ` Wolfgang Denk
2011-10-11  5:51         ` Aaron Williams
2011-10-11  5:52         ` Heiko Schocher
2011-10-10 10:50 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-10-10 15:19   ` Mike Frysinger
2011-10-10 15:31     ` Stefano Babic
2011-10-10 17:51       ` Mike Frysinger
2011-10-11 17:30         ` Stefano Babic
2011-10-11 17:46           ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E92BB35.1040607@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox