From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 10 Oct 2011 11:30:29 +0200 Subject: [U-Boot] [PATCH 05/13] I2c: add missing i2c_set_bus_num to mxc_i2c In-Reply-To: <4E92B1DD.6040802@denx.de> References: <1318091769-30979-1-git-send-email-sbabic@denx.de> <1318091769-30979-6-git-send-email-sbabic@denx.de> <4E92B1DD.6040802@denx.de> Message-ID: <4E92BB35.1040607@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/10/2011 10:50 AM, Heiko Schocher wrote: > Hello Stefano, > > Stefano Babic wrote: >> The function i2c_set_bus_num() is used on most SOCs. >> The driver does not support multiple I2C busses, and >> an empty function is added to be compatible with general code >> (example: PMIC driver). >> >> Signed-off-by: Stefano Babic >> Cc: Heiko Schocher >> --- >> drivers/i2c/mxc_i2c.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) > > Hmm... it would be better to add a weak function in > u-boot/common/cmd_i2c.c ... as it is done for i2c_set_bus_speed() > and i2c_get_bus_speed() functions. Good idea, I missed it..changed in V2. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================