From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation
Date: Mon, 10 Oct 2011 15:00:53 -0500 [thread overview]
Message-ID: <4E934EF5.9030302@freescale.com> (raw)
In-Reply-To: <20111009194336.C84971408775@gemini.denx.de>
On 10/09/2011 02:43 PM, Wolfgang Denk wrote:
> Dear Lukasz Majewski,
>
> In message <20111007093950.17d94287@lmajewski.digital.local> you wrote:
>>
>> Most warnings are related to lines over 80 characters.
>> This code is a debug code. As fair as I remember debug print code shall
>> not be break in Linux kernel for easier debugging.
>
> Can you please point me to the respective entry in the CodingStyle
> file?
Note the last sentence:
> Chapter 2: Breaking long lines and strings
>
> Coding style is all about readability and maintainability using commonly
> available tools.
>
> The limit on the length of lines is 80 columns and this is a strongly
> preferred limit.
>
> Statements longer than 80 columns will be broken into sensible chunks, unless
> exceeding 80 columns significantly increases readability and does not hide
> information. Descendants are always substantially shorter than the parent and
> are placed substantially to the right. The same applies to function headers
> with a long argument list. However, never break user-visible strings such as
> printk messages, because that breaks the ability to grep for them.
-Scott
next prev parent reply other threads:[~2011-10-10 20:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 14:29 [U-Boot] [PATCH v2 0/5] usb:gadget USB Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation Lukasz Majewski
2011-07-13 14:43 ` Vitaly Kuzmichev
2011-07-14 8:14 ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-10-06 22:10 ` [U-Boot] [PATCH " Wolfgang Denk
2011-10-07 7:39 ` Lukasz Majewski
2011-10-09 19:43 ` Wolfgang Denk
2011-10-10 20:00 ` Scott Wood [this message]
2011-10-10 20:38 ` Wolfgang Denk
2011-10-10 20:55 ` Scott Wood
2011-10-10 21:54 ` Wolfgang Denk
2011-10-10 22:00 ` Scott Wood
2011-07-13 14:29 ` [U-Boot] [PATCH v2 2/5] usb:gadget:s5p Enabling the USB Gadget framework at GONI Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files from Linux kernel Lukasz Majewski
2011-10-06 22:10 ` Wolfgang Denk
2011-10-07 7:28 ` Lukasz Majewski
2011-10-07 8:25 ` Wolfgang Denk
2011-07-13 14:29 ` [U-Boot] [PATCH v2 4/5] usb:gadget: USB Mass Storage Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 5/5] usb:gadget:s5p Support for USB Mass Storage Gadget on GONI Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E934EF5.9030302@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox