From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 10 Oct 2011 15:00:53 -0500 Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation In-Reply-To: <20111009194336.C84971408775@gemini.denx.de> References: <1310567392-29082-1-git-send-email-l.majewski@samsung.com> <1310567392-29082-2-git-send-email-l.majewski@samsung.com> <20111006221048.39BEC140874A@gemini.denx.de> <20111007093950.17d94287@lmajewski.digital.local> <20111009194336.C84971408775@gemini.denx.de> Message-ID: <4E934EF5.9030302@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/09/2011 02:43 PM, Wolfgang Denk wrote: > Dear Lukasz Majewski, > > In message <20111007093950.17d94287@lmajewski.digital.local> you wrote: >> >> Most warnings are related to lines over 80 characters. >> This code is a debug code. As fair as I remember debug print code shall >> not be break in Linux kernel for easier debugging. > > Can you please point me to the respective entry in the CodingStyle > file? Note the last sentence: > Chapter 2: Breaking long lines and strings > > Coding style is all about readability and maintainability using commonly > available tools. > > The limit on the length of lines is 80 columns and this is a strongly > preferred limit. > > Statements longer than 80 columns will be broken into sensible chunks, unless > exceeding 80 columns significantly increases readability and does not hide > information. Descendants are always substantially shorter than the parent and > are placed substantially to the right. The same applies to function headers > with a long argument list. However, never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. -Scott