From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] NAND: davinci: choose correct 1-bit h/w ECC reg
Date: Mon, 10 Oct 2011 15:29:00 -0500 [thread overview]
Message-ID: <4E93558C.1070602@freescale.com> (raw)
In-Reply-To: <E1R9Dgr-00053H-7g@rhodium.platinum.guralp.com>
On 09/26/2011 11:02 AM, Laurence Withers wrote:
> In nand_davinci_readecc(), select the correct NANDF<n>ECC register based
> on CONFIG_SYS_NAND_CS rather than hardcoding the choice of NANDF1ECC.
> This allows 1-bit hardware ECC to work with chip select other than CS2.
>
> Note this now matches the usage in nand_davinci_enable_hwecc(), which
> already had the correct handling, and allows refactoring to a single
> function encapsulating the register read.
>
> Without this fix, writing NAND pages to a chip not wired to CS2 would
> result in in the ECC calculation always returning FFFFFF for each
> 512-byte segment, and reading back a correctly written page (one with
> ECC intact) would always fail. With this fix, the ECC is written and
> verified correctly.
>
> Signed-off-by: Laurence Withers <lwithers@guralp.com>
> ---
> Changes for v2:
> Add Signed-off-by to commit message.
> ---
> drivers/mtd/nand/davinci_nand.c | 26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
Applied to u-boot-nand-flash
-Scott
next prev parent reply other threads:[~2011-10-10 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 16:02 [U-Boot] [PATCH] NAND: davinci: choose correct 1-bit h/w ECC reg Laurence Withers
2011-09-26 16:02 ` [U-Boot] [PATCH v2] " Laurence Withers
2011-10-10 13:45 ` Laurence Withers
2011-10-10 20:29 ` Scott Wood [this message]
2011-09-26 16:02 ` [U-Boot] [PATCH] " Laurence Withers
2011-09-28 8:58 ` Sergei Shtylyov
2011-09-29 10:18 ` Laurence Withers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E93558C.1070602@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox